From: Chen Gong <g.chen@freescale.com>
To: linux-mtd@lists.infradead.org
Cc: david-b@pacbell.net, Chen Gong <clumsycg@gmail.com>,
Chen Gong <g.chen@freescale.com>,
dwmw2@infradead.org
Subject: [PATCH] [MTD] m25p80.c erase enhance (v2)
Date: Tue, 21 Oct 2008 11:15:09 +0800 [thread overview]
Message-ID: <1224558909-4254-1-git-send-email-g.chen@freescale.com> (raw)
To avoid confusion, according to the suggestion from
David Brownell <david-b@pacbell.net>, cleanup some
terminology as follows:
OPCODE_BE ==> OPCODE_CHIP_ERASE
erase_block ==> erase_chip
Signed-Off-by: Chen Gong <clumsycg@gmail.com>
---
drivers/mtd/devices/m25p80.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 76a7675..b95aadf 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -39,7 +39,7 @@
#define OPCODE_PP 0x02 /* Page program (up to 256 bytes) */
#define OPCODE_BE_4K 0x20 /* Erase 4KiB block */
#define OPCODE_BE_32K 0x52 /* Erase 32KiB block */
-#define OPCODE_BE 0xc7 /* Erase whole flash block */
+#define OPCODE_CHIP_ERASE 0xc7 /* Erase whole flash block */
#define OPCODE_SE 0xd8 /* Sector erase (usually 64KiB) */
#define OPCODE_RDID 0x9f /* Read JEDEC ID */
@@ -167,7 +167,7 @@ static int wait_till_ready(struct m25p *flash)
*
* Returns 0 if successful, non-zero otherwise.
*/
-static int erase_block(struct m25p *flash)
+static int erase_chip(struct m25p *flash)
{
DEBUG(MTD_DEBUG_LEVEL3, "%s: %s %dKiB\n",
flash->spi->dev.bus_id, __func__,
@@ -181,7 +181,7 @@ static int erase_block(struct m25p *flash)
write_enable(flash);
/* Set up command buffer. */
- flash->command[0] = OPCODE_BE;
+ flash->command[0] = OPCODE_CHIP_ERASE;
spi_write(flash->spi, flash->command, 1);
@@ -255,7 +255,7 @@ static int m25p80_erase(struct mtd_info *mtd, struct erase_info *instr)
*/
/* now erase those sectors */
- if (len == flash->mtd.size && erase_block(flash)) {
+ if (len == flash->mtd.size && erase_chip(flash)) {
instr->state = MTD_ERASE_FAILED;
mutex_unlock(&flash->lock);
return -EIO;
--
1.5.4
next reply other threads:[~2008-10-21 3:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 3:15 Chen Gong [this message]
2008-10-21 4:20 ` [PATCH] [MTD] m25p80.c erase enhance (v2) David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224558909-4254-1-git-send-email-g.chen@freescale.com \
--to=g.chen@freescale.com \
--cc=clumsycg@gmail.com \
--cc=david-b@pacbell.net \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox