Re: [PATCH][nandsim] FIX RAM wasting via kmalloc

Artem Bityutskiy
2008-10-29T09:27:10Z

On Mon, 2008-10-27 at 12:59 +0000, Alexey Korolev wrote:
> Hi,
>
> > > Nandsim consumes ~2x more RAM than the density of simulated device.
> > > It becomes critical if we need to simulate 256MB NAND and run stress tests
> > > on it.
> >
> > I'm applying your patch to our local tree, just to test it. But there
> > is a trailing white-space.
> >
> > [dedekind@gollum ubifs-2.6]$ git-am nandsim
> > Applying FIX RAM wasting via kmalloc
> > .dotest/patch:64: trailing whitespace.
> > * then kernel memory alloc runs writeback which goes to
> > the FS
> > warning: 1 line adds whitespace errors.
> >
> > :-)
> >
> Thanks. I removed the trailing space. Also for just a case did an addtional
> tests to make sure it works fine.
> I think this one should be better :)?

I suggest you to re-send your patch again, with nice commit comments,
because when I applied this patch using git-am, I had to edit the text
to remove junk ">" symbols. It is just nice if your patch does not
require much editing.

Feel free to add:

Tested-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Acked-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Thanks.