public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* (no subject)
@ 2008-11-18  7:33 Bryan Wu
  2008-11-18  7:33 ` [PATCH 1/2] mtd/maps: blackfin async flash maps - fix bug: dont leak resources when initializing in case of errors Bryan Wu
  2008-11-18  7:33 ` [PATCH 2/2] mtd/maps: bfin-async mtd driver needs complex mappings Bryan Wu
  0 siblings, 2 replies; 3+ messages in thread
From: Bryan Wu @ 2008-11-18  7:33 UTC (permalink / raw)
  To: dwmw2, linux-mtd; +Cc: linux-kernel



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] mtd/maps: blackfin async flash maps - fix bug: dont leak resources when initializing in case of errors
  2008-11-18  7:33 Bryan Wu
@ 2008-11-18  7:33 ` Bryan Wu
  2008-11-18  7:33 ` [PATCH 2/2] mtd/maps: bfin-async mtd driver needs complex mappings Bryan Wu
  1 sibling, 0 replies; 3+ messages in thread
From: Bryan Wu @ 2008-11-18  7:33 UTC (permalink / raw)
  To: dwmw2, linux-mtd; +Cc: Bryan Wu, linux-kernel, Mike Frysinger

From: Mike Frysinger <vapier.adi@gmail.com>

Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
 drivers/mtd/maps/bfin-async-flash.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/maps/bfin-async-flash.c b/drivers/mtd/maps/bfin-async-flash.c
index 6fec86a..576611f 100644
--- a/drivers/mtd/maps/bfin-async-flash.c
+++ b/drivers/mtd/maps/bfin-async-flash.c
@@ -152,14 +152,18 @@ static int __devinit bfin_flash_probe(struct platform_device *pdev)
 
 	if (gpio_request(state->enet_flash_pin, DRIVER_NAME)) {
 		pr_devinit(KERN_ERR DRIVER_NAME ": Failed to request gpio %d\n", state->enet_flash_pin);
+		kfree(state);
 		return -EBUSY;
 	}
 	gpio_direction_output(state->enet_flash_pin, 1);
 
 	pr_devinit(KERN_NOTICE DRIVER_NAME ": probing %d-bit flash bus\n", state->map.bankwidth * 8);
 	state->mtd = do_map_probe(memory->name, &state->map);
-	if (!state->mtd)
+	if (!state->mtd) {
+		gpio_free(state->enet_flash_pin);
+		kfree(state);
 		return -ENXIO;
+	}
 
 #ifdef CONFIG_MTD_PARTITIONS
 	ret = parse_mtd_partitions(state->mtd, part_probe_types, &pdata->parts, 0);
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] mtd/maps: bfin-async mtd driver needs complex mappings
  2008-11-18  7:33 Bryan Wu
  2008-11-18  7:33 ` [PATCH 1/2] mtd/maps: blackfin async flash maps - fix bug: dont leak resources when initializing in case of errors Bryan Wu
@ 2008-11-18  7:33 ` Bryan Wu
  1 sibling, 0 replies; 3+ messages in thread
From: Bryan Wu @ 2008-11-18  7:33 UTC (permalink / raw)
  To: dwmw2, linux-mtd; +Cc: Bryan Wu, linux-kernel, Mike Frysinger

From: Mike Frysinger <vapier.adi@gmail.com>

Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
 drivers/mtd/maps/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig
index 5ea1693..db68e70 100644
--- a/drivers/mtd/maps/Kconfig
+++ b/drivers/mtd/maps/Kconfig
@@ -480,7 +480,7 @@ config MTD_PCMCIA_ANONYMOUS
 
 config MTD_BFIN_ASYNC
 	tristate "Blackfin BF533-STAMP Flash Chip Support"
-	depends on BFIN533_STAMP && MTD_CFI
+	depends on BFIN533_STAMP && MTD_CFI && MTD_COMPLEX_MAPPINGS
 	select MTD_PARTITIONS
 	default y
 	help
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-18  7:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-18  7:33 Bryan Wu
2008-11-18  7:33 ` [PATCH 1/2] mtd/maps: blackfin async flash maps - fix bug: dont leak resources when initializing in case of errors Bryan Wu
2008-11-18  7:33 ` [PATCH 2/2] mtd/maps: bfin-async mtd driver needs complex mappings Bryan Wu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox