From: Artem Bityutskiy <dedekind@infradead.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-mtd@lists.infradead.org, Nicolas Pitre <nico@cam.org>
Subject: Re: [PATCH mtd-utils] fix CFLAGS handling wrt cross compilation
Date: Fri, 21 Nov 2008 12:41:00 +0200 [thread overview]
Message-ID: <1227264060.3954.55.camel@sauron> (raw)
In-Reply-To: <8bd0f97a0811191752l69f5f93eg72692338ce2c6892@mail.gmail.com>
On Wed, 2008-11-19 at 20:52 -0500, Mike Frysinger wrote:
> On Wed, Nov 19, 2008 at 13:31, Nicolas Pitre wrote:
> > Let's have the "new ubi-utils" makefile handle CFLAGS like the other
> > makefiles. This is important when cross compiling and CFLAGS is
> > externally provided. Without this, local include files are not found due
> > to the various -I arguments which are then lost.
> >
> > Signed-off-by: Nicolas Pitre <nico@marvell.com>
>
> i dont think sticking CFLAGS into CPPFLAGS is right. they're separate
> on purpose. you also break custom CPPFLAG injection here ... CPPFLAGS
> should be treated just like CFLAGS: appended, not strictly set.
May be, I'm bad in Makefile stuff. But this is what the rest of Makefile
files in mtd-utils do, so I've applied Nicolas' patch.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2008-11-21 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 18:31 [PATCH mtd-utils] fix CFLAGS handling wrt cross compilation Nicolas Pitre
2008-11-20 1:52 ` Mike Frysinger
2008-11-21 10:41 ` Artem Bityutskiy [this message]
2008-11-21 10:38 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227264060.3954.55.camel@sauron \
--to=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@cam.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox