From: Artem Bityutskiy <dedekind@infradead.org>
To: Corentin Chary <corentincj@iksaif.net>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 3/3] UBI: is_mapped operation via ioctl
Date: Mon, 05 Jan 2009 16:33:29 +0200 [thread overview]
Message-ID: <1231166009.6608.20.camel@localhost.localdomain> (raw)
In-Reply-To: <71cd59b00901050607l4356c850y2be8ea93d8437fbd@mail.gmail.com>
On Mon, 2009-01-05 at 15:07 +0100, Corentin Chary wrote:
> diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
> index bcff3a0..a65c4ab 100644
> --- a/include/mtd/ubi-user.h
> +++ b/include/mtd/ubi-user.h
> @@ -137,6 +137,8 @@
> #define UBI_IOMAP _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
> /* Unmap an eraseblock */
> #define UBI_IOUNMAP _IOW(UBI_VOL_IOC_MAGIC, 4, int32_t)
> +/* check whether an eraseblock is mapped */
Bettert to start from capital "C".
> +#define UBI_IOISMAP _IOW(UBI_VOL_IOC_MAGIC, 5, int32_t)
I think this should be _IOR instead.
_IOR: data is transferred from kernel to user-space
_IOW: data is transferred from user-space to kernel
_IORW: both directions
Otherwise, the patches look OK for me.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-01-05 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 14:07 [PATCH 3/3] UBI: is_mapped operation via ioctl Corentin Chary
2009-01-05 14:33 ` Artem Bityutskiy [this message]
2009-01-06 9:25 ` Corentin Chary
2009-01-06 11:58 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 9:22 [PATCH 0/3] Export UBI map/unmap/is_mapped in userspace v2 Corentin Chary
2009-01-07 9:29 ` [PATCH 3/3] UBI: is_mapped operation via ioctl Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231166009.6608.20.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=corentincj@iksaif.net \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox