* [PATCH 3/3] UBI: is_mapped operation via ioctl
@ 2009-01-05 14:07 Corentin Chary
2009-01-05 14:33 ` Artem Bityutskiy
0 siblings, 1 reply; 5+ messages in thread
From: Corentin Chary @ 2009-01-05 14:07 UTC (permalink / raw)
To: linux-mtd
From: Corentin Chary <corentincj@iksaif.net>
UBI: is_mapped operation via ioctl
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
drivers/mtd/ubi/cdev.c | 12 ++++++++++++
include/mtd/ubi-user.h | 2 ++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 7a9080c..1bf21eb 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -542,6 +542,18 @@ static int vol_cdev_ioctl(struct inode *inode,
struct file *file,
err = ubi_leb_unmap(desc, lnum);
break;
}
+ case UBI_IOISMAP:
+ {
+ int32_t lnum;
+
+ err = get_user(lnum, (__user int32_t *)argp);
+ if (err) {
+ err = -EFAULT;
+ break;
+ }
+ err = ubi_is_mapped(desc, lnum);
+ break;
+ }
#endif
diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
index bcff3a0..a65c4ab 100644
--- a/include/mtd/ubi-user.h
+++ b/include/mtd/ubi-user.h
@@ -137,6 +137,8 @@
#define UBI_IOMAP _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
/* Unmap an eraseblock */
#define UBI_IOUNMAP _IOW(UBI_VOL_IOC_MAGIC, 4, int32_t)
+/* check whether an eraseblock is mapped */
+#define UBI_IOISMAP _IOW(UBI_VOL_IOC_MAGIC, 5, int32_t)
/* Maximum MTD device name length supported by UBI */
#define MAX_UBI_MTD_NAME_LEN 127
--
1.6.0.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] UBI: is_mapped operation via ioctl
2009-01-05 14:07 [PATCH 3/3] UBI: is_mapped operation via ioctl Corentin Chary
@ 2009-01-05 14:33 ` Artem Bityutskiy
2009-01-06 9:25 ` Corentin Chary
0 siblings, 1 reply; 5+ messages in thread
From: Artem Bityutskiy @ 2009-01-05 14:33 UTC (permalink / raw)
To: Corentin Chary; +Cc: linux-mtd
On Mon, 2009-01-05 at 15:07 +0100, Corentin Chary wrote:
> diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
> index bcff3a0..a65c4ab 100644
> --- a/include/mtd/ubi-user.h
> +++ b/include/mtd/ubi-user.h
> @@ -137,6 +137,8 @@
> #define UBI_IOMAP _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
> /* Unmap an eraseblock */
> #define UBI_IOUNMAP _IOW(UBI_VOL_IOC_MAGIC, 4, int32_t)
> +/* check whether an eraseblock is mapped */
Bettert to start from capital "C".
> +#define UBI_IOISMAP _IOW(UBI_VOL_IOC_MAGIC, 5, int32_t)
I think this should be _IOR instead.
_IOR: data is transferred from kernel to user-space
_IOW: data is transferred from user-space to kernel
_IORW: both directions
Otherwise, the patches look OK for me.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] UBI: is_mapped operation via ioctl
2009-01-05 14:33 ` Artem Bityutskiy
@ 2009-01-06 9:25 ` Corentin Chary
2009-01-06 11:58 ` Artem Bityutskiy
0 siblings, 1 reply; 5+ messages in thread
From: Corentin Chary @ 2009-01-06 9:25 UTC (permalink / raw)
To: dedekind; +Cc: linux-mtd
> Otherwise, the patches look OK for me.
Do you want me to send the corrected patch or is it ok ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] UBI: is_mapped operation via ioctl
2009-01-06 9:25 ` Corentin Chary
@ 2009-01-06 11:58 ` Artem Bityutskiy
0 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2009-01-06 11:58 UTC (permalink / raw)
To: Corentin Chary; +Cc: linux-mtd
On Tue, 2009-01-06 at 10:25 +0100, Corentin Chary wrote:
> > Otherwise, the patches look OK for me.
> Do you want me to send the corrected patch or is it ok ?
No, thanks, I think I can tweak your patch myself a bit later.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] UBI: is_mapped operation via ioctl
2009-01-07 9:22 [PATCH 0/3] Export UBI map/unmap/is_mapped in userspace v2 Corentin Chary
@ 2009-01-07 9:29 ` Corentin Chary
0 siblings, 0 replies; 5+ messages in thread
From: Corentin Chary @ 2009-01-07 9:29 UTC (permalink / raw)
To: linux-mtd
From dbccb9a0ed4d9b9b45cbad2d13432bad6e9ca886 Mon Sep 17 00:00:00 2001
From: Corentin Chary <corentincj@iksaif.net>
Date: Mon, 5 Jan 2009 14:48:59 +0100
UBI: is_mapped operation via ioctl
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
drivers/mtd/ubi/cdev.c | 12 ++++++++++++
include/mtd/ubi-user.h | 2 ++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 7a9080c..1bf21eb 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -542,6 +542,18 @@ static int vol_cdev_ioctl(struct inode *inode, struct file *file,
err = ubi_leb_unmap(desc, lnum);
break;
}
+ case UBI_IOISMAP:
+ {
+ int32_t lnum;
+
+ err = get_user(lnum, (__user int32_t *)argp);
+ if (err) {
+ err = -EFAULT;
+ break;
+ }
+ err = ubi_is_mapped(desc, lnum);
+ break;
+ }
#endif
diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
index bcff3a0..a65c4ab 100644
--- a/include/mtd/ubi-user.h
+++ b/include/mtd/ubi-user.h
@@ -137,6 +137,8 @@
#define UBI_IOMAP _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
/* Unmap an eraseblock */
#define UBI_IOUNMAP _IOW(UBI_VOL_IOC_MAGIC, 4, int32_t)
+/* Check whether an eraseblock is mapped */
+#define UBI_IOISMAP _IOR(UBI_VOL_IOC_MAGIC, 5, int32_t)
/* Maximum MTD device name length supported by UBI */
#define MAX_UBI_MTD_NAME_LEN 127
--
1.6.0.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-01-07 9:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-05 14:07 [PATCH 3/3] UBI: is_mapped operation via ioctl Corentin Chary
2009-01-05 14:33 ` Artem Bityutskiy
2009-01-06 9:25 ` Corentin Chary
2009-01-06 11:58 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 9:22 [PATCH 0/3] Export UBI map/unmap/is_mapped in userspace v2 Corentin Chary
2009-01-07 9:29 ` [PATCH 3/3] UBI: is_mapped operation via ioctl Corentin Chary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox