public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/3] UBI: map operation via ioctl
@ 2009-01-05 14:05 Corentin Chary
  2009-01-06 15:38 ` Artem Bityutskiy
  0 siblings, 1 reply; 5+ messages in thread
From: Corentin Chary @ 2009-01-05 14:05 UTC (permalink / raw)
  To: linux-mtd

From: Corentin Chary <corentincj@iksaif.net>

UBI: map operation via ioctl

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 drivers/mtd/ubi/cdev.c |   13 +++++++++++++
 include/mtd/ubi-user.h |   16 ++++++++++++++++
 2 files changed, 29 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 98cf31e..db47121 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -518,6 +518,19 @@ static int vol_cdev_ioctl(struct inode *inode,
struct file *file,
 		err = ubi_wl_flush(ubi);
 		break;
 	}
+	case UBI_IOMAP:
+	{
+		struct ubi_map_req req;
+		err = copy_from_user(&req, argp,
+				sizeof(struct ubi_map_req));
+		if (err) {
+			err = -EFAULT;
+			break;
+		}
+		err = ubi_leb_map(desc, req.lnum, req.dtype);
+		break;
+	}
+
 #endif

 	default:
diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
index ccdc562..8222f12 100644
--- a/include/mtd/ubi-user.h
+++ b/include/mtd/ubi-user.h
@@ -133,6 +133,9 @@
 #define UBI_IOCEBER _IOW(UBI_VOL_IOC_MAGIC, 1, int32_t)
 /* An atomic eraseblock change command */
 #define UBI_IOCEBCH _IOW(UBI_VOL_IOC_MAGIC, 2, int32_t)
+/* Map an eraseblock */
+#define UBI_IOMAP   _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
+

 /* Maximum MTD device name length supported by UBI */
 #define MAX_UBI_MTD_NAME_LEN 127
@@ -319,4 +322,17 @@ struct ubi_leb_change_req {
 	int8_t  padding[7];
 } __attribute__ ((packed));

+/**
+ * struct ubi_map_req - a data structure used in map
+ *                      eraseblock requests.
+ * @lnum: logical eraseblock number to change
+ * @dtype: data type (%UBI_LONGTERM, %UBI_SHORTTERM, %UBI_UNKNOWN)
+ * @padding: reserved for future, not used, has to be zeroed
+ */
+struct ubi_map_req {
+	int32_t lnum;
+	int8_t  dtype;
+	int8_t  padding[3];
+} __attribute__ ((packed));
+
 #endif /* __UBI_USER_H__ */
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] UBI: map operation via ioctl
  2009-01-05 14:05 [PATCH 1/3] UBI: map operation via ioctl Corentin Chary
@ 2009-01-06 15:38 ` Artem Bityutskiy
  2009-01-06 17:20   ` Corentin Chary
  0 siblings, 1 reply; 5+ messages in thread
From: Artem Bityutskiy @ 2009-01-06 15:38 UTC (permalink / raw)
  To: Corentin Chary; +Cc: linux-mtd

On Mon, 2009-01-05 at 15:05 +0100, Corentin Chary wrote:
> From: Corentin Chary <corentincj@iksaif.net>
> 
> UBI: map operation via ioctl
> 
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>

Argh. The patch is corrupted:

patching file drivers/mtd/ubi/cdev.c
patch: **** malformed patch at line 11: struct file *file,

Could you please glance at Documentation/SubmittingPatches in the
kernel tree? Could you please re-send the series properly? Or send
me the patches as an attachment. Thanks.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] UBI: map operation via ioctl
  2009-01-06 15:38 ` Artem Bityutskiy
@ 2009-01-06 17:20   ` Corentin Chary
  2009-01-07  8:54     ` Artem Bityutskiy
  0 siblings, 1 reply; 5+ messages in thread
From: Corentin Chary @ 2009-01-06 17:20 UTC (permalink / raw)
  To: dedekind; +Cc: linux-mtd

From bafefa6ed036173c65b7f51c6a4a4ce5004ad09f Mon Sep 17 00:00:00 2001
From: Corentin Chary <corentincj@iksaif.net>
Date: Mon, 5 Jan 2009 14:44:11 +0100
Subject: [PATCH 1/3] UBI: map operation via ioctl

UBI: map operation via ioctl

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 drivers/mtd/ubi/cdev.c |   13 +++++++++++++
 include/mtd/ubi-user.h |   16 ++++++++++++++++
 2 files changed, 29 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 98cf31e..db47121 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -518,6 +518,19 @@ static int vol_cdev_ioctl(struct inode *inode, struct file *file,
 		err = ubi_wl_flush(ubi);
 		break;
 	}
+	case UBI_IOMAP:
+	{
+		struct ubi_map_req req;
+		err = copy_from_user(&req, argp,
+				sizeof(struct ubi_map_req));
+		if (err) {
+			err = -EFAULT;
+			break;
+		}
+		err = ubi_leb_map(desc, req.lnum, req.dtype);
+		break;
+	}
+
 #endif
 
 	default:
diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
index ccdc562..8222f12 100644
--- a/include/mtd/ubi-user.h
+++ b/include/mtd/ubi-user.h
@@ -133,6 +133,9 @@
 #define UBI_IOCEBER _IOW(UBI_VOL_IOC_MAGIC, 1, int32_t)
 /* An atomic eraseblock change command */
 #define UBI_IOCEBCH _IOW(UBI_VOL_IOC_MAGIC, 2, int32_t)
+/* Map an eraseblock */
+#define UBI_IOMAP   _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
+
 
 /* Maximum MTD device name length supported by UBI */
 #define MAX_UBI_MTD_NAME_LEN 127
@@ -319,4 +322,17 @@ struct ubi_leb_change_req {
 	int8_t  padding[7];
 } __attribute__ ((packed));
 
+/**
+ * struct ubi_map_req - a data structure used in map
+ *                      eraseblock requests.
+ * @lnum: logical eraseblock number to change
+ * @dtype: data type (%UBI_LONGTERM, %UBI_SHORTTERM, %UBI_UNKNOWN)
+ * @padding: reserved for future, not used, has to be zeroed
+ */
+struct ubi_map_req {
+	int32_t lnum;
+	int8_t  dtype;
+	int8_t  padding[3];
+} __attribute__ ((packed));
+
 #endif /* __UBI_USER_H__ */
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] UBI: map operation via ioctl
  2009-01-06 17:20   ` Corentin Chary
@ 2009-01-07  8:54     ` Artem Bityutskiy
  0 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2009-01-07  8:54 UTC (permalink / raw)
  To: Corentin Chary; +Cc: linux-mtd

On Tue, 2009-01-06 at 18:20 +0100, Corentin Chary wrote:
> From bafefa6ed036173c65b7f51c6a4a4ce5004ad09f Mon Sep 17 00:00:00 2001
> From: Corentin Chary <corentincj@iksaif.net>
> Date: Mon, 5 Jan 2009 14:44:11 +0100
> Subject: [PATCH 1/3] UBI: map operation via ioctl
> 
> UBI: map operation via ioctl
> 
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>

Now this patch applies, but the second one does not. Could you please
resend whole series instead?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] UBI: map operation via ioctl
  2009-01-07  9:22 [PATCH 0/3] Export UBI map/unmap/is_mapped in userspace v2 Corentin Chary
@ 2009-01-07  9:25 ` Corentin Chary
  0 siblings, 0 replies; 5+ messages in thread
From: Corentin Chary @ 2009-01-07  9:25 UTC (permalink / raw)
  To: linux-mtd

From bafefa6ed036173c65b7f51c6a4a4ce5004ad09f Mon Sep 17 00:00:00 2001
From: Corentin Chary <corentincj@iksaif.net>
Date: Mon, 5 Jan 2009 14:44:11 +0100

UBI: map operation via ioctl

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 drivers/mtd/ubi/cdev.c |   13 +++++++++++++
 include/mtd/ubi-user.h |   16 ++++++++++++++++
 2 files changed, 29 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 98cf31e..db47121 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -518,6 +518,19 @@ static int vol_cdev_ioctl(struct inode *inode, struct file *file,
 		err = ubi_wl_flush(ubi);
 		break;
 	}
+	case UBI_IOMAP:
+	{
+		struct ubi_map_req req;
+		err = copy_from_user(&req, argp,
+				sizeof(struct ubi_map_req));
+		if (err) {
+			err = -EFAULT;
+			break;
+		}
+		err = ubi_leb_map(desc, req.lnum, req.dtype);
+		break;
+	}
+
 #endif
 
 	default:
diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
index ccdc562..8222f12 100644
--- a/include/mtd/ubi-user.h
+++ b/include/mtd/ubi-user.h
@@ -133,6 +133,9 @@
 #define UBI_IOCEBER _IOW(UBI_VOL_IOC_MAGIC, 1, int32_t)
 /* An atomic eraseblock change command */
 #define UBI_IOCEBCH _IOW(UBI_VOL_IOC_MAGIC, 2, int32_t)
+/* Map an eraseblock */
+#define UBI_IOMAP   _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
+
 
 /* Maximum MTD device name length supported by UBI */
 #define MAX_UBI_MTD_NAME_LEN 127
@@ -319,4 +322,17 @@ struct ubi_leb_change_req {
 	int8_t  padding[7];
 } __attribute__ ((packed));
 
+/**
+ * struct ubi_map_req - a data structure used in map
+ *                      eraseblock requests.
+ * @lnum: logical eraseblock number to change
+ * @dtype: data type (%UBI_LONGTERM, %UBI_SHORTTERM, %UBI_UNKNOWN)
+ * @padding: reserved for future, not used, has to be zeroed
+ */
+struct ubi_map_req {
+	int32_t lnum;
+	int8_t  dtype;
+	int8_t  padding[3];
+} __attribute__ ((packed));
+
 #endif /* __UBI_USER_H__ */
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-01-07  9:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-05 14:05 [PATCH 1/3] UBI: map operation via ioctl Corentin Chary
2009-01-06 15:38 ` Artem Bityutskiy
2009-01-06 17:20   ` Corentin Chary
2009-01-07  8:54     ` Artem Bityutskiy
  -- strict thread matches above, loose matches on Subject: below --
2009-01-07  9:22 [PATCH 0/3] Export UBI map/unmap/is_mapped in userspace v2 Corentin Chary
2009-01-07  9:25 ` [PATCH 1/3] UBI: map operation via ioctl Corentin Chary

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox