Missing ioctl32 for ubi

Missing ioctl32 for ubi

[Geert Uytterhoeven]

	Hi Артём,

When running ubimkvol (32-bit userland) on a PS3 (ppc64), I get:

| # ubimkvol /dev/ubi0 -N test -s 200MiB
| ubimkvol: error!: cannot UBI create volume
|           error 22 (Invalid argument)
| #

and in the kernel log:

| ioctl32(ubimkvol:2207): Unknown cmd fd(3) cmd(80986f00){t:'o';sz:152} arg(ff88a888) on /dev/ubi0

This is on 2.6.29-rc1+.

Спасибо!

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010

Re: Missing ioctl32 for ubi

[Artem Bityutskiy]

On Wed, 2009-01-14 at 14:48 +0100, Geert Uytterhoeven wrote:
> 	Hi Артём,
> 
> When running ubimkvol (32-bit userland) on a PS3 (ppc64), I get:
> 
> | # ubimkvol /dev/ubi0 -N test -s 200MiB
> | ubimkvol: error!: cannot UBI create volume
> |           error 22 (Invalid argument)
> | #
> 
> and in the kernel log:
> 
> | ioctl32(ubimkvol:2207): Unknown cmd fd(3) cmd(80986f00){t:'o';sz:152} arg(ff88a888) on /dev/ubi0
> 
> This is on 2.6.29-rc1+.

Hmm, frankly I have no idea what this could be. I'll look and try ti
figure out, though.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

Re: Missing ioctl32 for ubi

[Geert Uytterhoeven]

	Hi Артём,

On Wed, 14 Jan 2009, Artem Bityutskiy wrote:
> On Wed, 2009-01-14 at 14:48 +0100, Geert Uytterhoeven wrote:
> > When running ubimkvol (32-bit userland) on a PS3 (ppc64), I get:
> > 
> > | # ubimkvol /dev/ubi0 -N test -s 200MiB
> > | ubimkvol: error!: cannot UBI create volume
> > |           error 22 (Invalid argument)
> > | #
> > 
> > and in the kernel log:
> > 
> > | ioctl32(ubimkvol:2207): Unknown cmd fd(3) cmd(80986f00){t:'o';sz:152} arg(ff88a888) on /dev/ubi0
> > 
> > This is on 2.6.29-rc1+.
> 
> Hmm, frankly I have no idea what this could be. I'll look and try ti
> figure out, though.

When running 32-bit userland on a 64-bit kernel, ioctls have to be translated.

I noticed the drivers/mtd/ubi/cdev.c:ubi_*cdev_operations structures don't have
.compat_ioctl entries, which would handle those translations.

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010

Re: Missing ioctl32 for ubi

[Artem Bityutskiy]

On Wed, 2009-01-14 at 15:12 +0100, Geert Uytterhoeven wrote:
> 	Hi Артём,
> 
> On Wed, 14 Jan 2009, Artem Bityutskiy wrote:
> > On Wed, 2009-01-14 at 14:48 +0100, Geert Uytterhoeven wrote:
> > > When running ubimkvol (32-bit userland) on a PS3 (ppc64), I get:
> > > 
> > > | # ubimkvol /dev/ubi0 -N test -s 200MiB
> > > | ubimkvol: error!: cannot UBI create volume
> > > |           error 22 (Invalid argument)
> > > | #
> > > 
> > > and in the kernel log:
> > > 
> > > | ioctl32(ubimkvol:2207): Unknown cmd fd(3) cmd(80986f00){t:'o';sz:152} arg(ff88a888) on /dev/ubi0
> > > 
> > > This is on 2.6.29-rc1+.
> > 
> > Hmm, frankly I have no idea what this could be. I'll look and try ti
> > figure out, though.
> 
> When running 32-bit userland on a 64-bit kernel, ioctls have to be translated.
> 
> I noticed the drivers/mtd/ubi/cdev.c:ubi_*cdev_operations structures don't have
> .compat_ioctl entries, which would handle those translations.

Oh, right. This is about implementing compat_ioctl's. I'll put this to
my TODO list and look at this unless you come up with a patch faster :-)

Thank you for noticing this.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)