From: Artem Bityutskiy <dedekind@infradead.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Corentin Chary <corentincj@iksaif.net>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] MTD: add fsync capability
Date: Fri, 06 Feb 2009 09:34:43 +0200 [thread overview]
Message-ID: <1233905683.17790.14.camel@localhost.localdomain> (raw)
In-Reply-To: <8bd0f97a0902051400t6c9e7525h28597ae442501751@mail.gmail.com>
On Thu, 2009-02-05 at 17:00 -0500, Mike Frysinger wrote:
> On Thu, Feb 5, 2009 at 16:25, Corentin Chary wrote:
> > +static int mtd_fsync(struct file *file, struct dentry *dentry, int datasync)
> > +{
> > + struct mtd_file_info *mfi = file->private_data;
> > + struct mtd_info *mtd = mfi->mtd;
> > +
> > + DEBUG(MTD_DEBUG_LEVEL0, "MTD_fsync\n");
> > +
> > + /* Only sync if opened RW */
> > + if ((file->f_mode & FMODE_WRITE) && mtd->sync)
> > + mtd->sync(mtd);
> > +
> > + return 0;
> > +} /* mtd_fsync */
>
> adding a comment to mark the end of a function isnt common ... i'd
> drop that. otherwise, the patch looks pretty straightforward to me,
> but i'm not a big VFS guru ;).
> -mike
The patch looks fine for me, except of the weird end comment, and
the ancient ugly "DEBUG(MTD_DEBUG_LEVEL0, "MTD_fsync\n");" ...
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-02-06 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 21:25 [PATCH 1/2] MTD: add fsync capability Corentin Chary
2009-02-05 21:25 ` [PATCH 2/2] UBI: " Corentin Chary
2009-02-06 8:01 ` Artem Bityutskiy
2009-02-05 22:00 ` [PATCH 1/2] MTD: " Mike Frysinger
2009-02-06 7:34 ` Artem Bityutskiy [this message]
2009-02-06 8:06 ` Corentin Chary
2009-02-06 8:10 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233905683.17790.14.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=corentincj@iksaif.net \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox