public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] flash_eraseall: remove support for clean markers
Date: Tue, 24 Feb 2009 09:44:17 +0200	[thread overview]
Message-ID: <1235461457.25808.14.camel@localhost.localdomain> (raw)
In-Reply-To: <20090223213600.GA15989@Chamillionaire.breakpoint.cc>

On Mon, 2009-02-23 at 22:36 +0100, Sebastian Andrzej Siewior wrote:
> clean markers are written by JFFS2 after mounting an empty flash media and
> are used to identify. This is done by the kernel while mounting an empty
> flash. The -j option should do the same thing after erasing a block.
> This patch rips it out since it seems to be broken and has no advantage over
> the kernel.
> 
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>

Hmm... I used -j long time ago and it worked. Also I can understand the
benefits of this options. I'd be much happier to see a fix.

Sorry, but I won't push your patch. But dwmw2, tglx1, or jwb can do this
if they consider it necessary.

I think someone instead should dig this and realize what exactly went
broke, why, and how can we fix this.

A patch which just prints "This option is broken" would be accepted by
me.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2009-02-24  7:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-23 21:36 [PATCH 1/2] flash_eraseall: remove support for clean markers Sebastian Andrzej Siewior
2009-02-24  7:44 ` Artem Bityutskiy [this message]
2009-02-24  7:48   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235461457.25808.14.camel@localhost.localdomain \
    --to=dedekind@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox