From: Artem Bityutskiy <dedekind@infradead.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] make sure compiler supports warning flags
Date: Thu, 26 Feb 2009 09:43:36 +0200 [thread overview]
Message-ID: <1235634216.25808.27.camel@localhost.localdomain> (raw)
In-Reply-To: <1235605127-2024-1-git-send-email-vapier@gentoo.org>
On Wed, 2009-02-25 at 18:38 -0500, Mike Frysinger wrote:
> Some compilers (like gcc-3.3) don't support all the newer -W flags that we
> are using. So import the compiler check found in the kernel and test each
> flag we add. The := is important so we only do the compiler tests once
> per `make` rather than every time we compile a file.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Looks fine for me, but I cannot really review this, so lets wait a
little, and if there are no complaints I'll push it. Thanks!
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-02-26 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 23:38 [PATCH] make sure compiler supports warning flags Mike Frysinger
2009-02-26 7:43 ` Artem Bityutskiy [this message]
2009-02-26 8:28 ` Mike Frysinger
2009-02-26 8:30 ` [PATCH v2] " Mike Frysinger
2009-02-27 16:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235634216.25808.27.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox