From: Artem Bityutskiy <dedekind@infradead.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] flash_eraseall: only add cleanmarkers on known flashtypes
Date: Tue, 24 Mar 2009 08:02:16 +0200 [thread overview]
Message-ID: <1237874536.14602.93.camel@localhost.localdomain> (raw)
In-Reply-To: <1237848138-18157-3-git-send-email-sebastian@breakpoint.cc>
On Mon, 2009-03-23 at 23:42 +0100, Sebastian Andrzej Siewior wrote:
> + switch (meminfo->type) {
> + case MTD_ROM:
> + case MTD_RAM:
> + case MTD_NORFLASH:
> cleanmarker.totlen = cpu_to_je32(sizeof(struct
> jffs2_unknown_node));
> - else {
> - struct nand_oobinfo oobinfo;
> + break;
> +
> + case MTD_DATAFLASH:
> + case MTD_UBIVOLUME:
> + fprintf(stderr, "JFFS2 layout not supported on this
> flash.\n");
> + return -1;
> + break;
This should also include MLC NAND flash. To make you nice patches
even better you should call MEMGETOOBSEL ioctl in case of NAND and
check if there is really enough bytes for clean-marker.
But I guess you do not have to do this.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-03-24 6:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 22:42 mtd-utils/flash_eraseall: tiny cleanup Sebastian Andrzej Siewior
2009-03-23 22:42 ` [PATCH] flash_eraseall: create two functions from existing code Sebastian Andrzej Siewior
2009-03-23 22:42 ` [PATCH] flash_eraseall: only add cleanmarkers on known flashtypes Sebastian Andrzej Siewior
2009-03-24 6:02 ` Artem Bityutskiy [this message]
2009-03-24 6:03 ` Artem Bityutskiy
2009-03-23 22:42 ` [RFC/PATCH] flash_eraseall: extra care if NOR flash is not BIT_WRITEABLE Sebastian Andrzej Siewior
2009-03-24 6:05 ` Artem Bityutskiy
2009-03-24 8:55 ` Sebastian Andrzej Siewior
2009-03-25 6:33 ` Artem Bityutskiy
2009-03-26 13:44 ` Jamie Lokier
2009-03-26 15:41 ` Sebastian Andrzej Siewior
2009-03-26 15:54 ` Ricard Wanderlof
2009-04-05 19:43 ` Sebastian Andrzej Siewior
2009-04-06 8:09 ` Ricard Wanderlof
2009-03-27 5:55 ` Artem Bityutskiy
2009-04-05 20:07 ` Sebastian Andrzej Siewior
2009-04-06 9:29 ` Artem Bityutskiy
2009-04-06 9:32 ` Artem Bityutskiy
2009-04-10 12:30 ` Artem Bityutskiy
2009-08-06 14:58 ` Sebastian Andrzej Siewior
2009-08-09 5:20 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237874536.14602.93.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox