Re: [resending][PATCH] [MTD] [NAND] nand_ecc.c: Bug fix in nand ecc

[Artem Bityutskiy <dedekind@infradead.org>]

On Wed, 2009-04-01 at 15:23 +0530, vimal singh wrote:
> I do not see this patch on tree, yet.
> 
> ------------------------------ Original Message -------------------------------
> Subject: [PATCH] [MTD] [NAND] nand_ecc.c: Bug fix in nand ecc
> From:    "vimal singh" <vimalsingh@ti.com>
> Date:    Mon, February 23, 2009 1:46 pm
> To:      linux-mtd@lists.infradead.org
> -------------------------------------------------------------------------------
> 
> Type of 'byte_addr' needed to change for 512 byte ecc support.
> 
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>

Probably because you did not try to CC the author of the
code and get his ack. Isn't this logical step to do?

I've CCed Frams.

> ---
> 
> diff --git a/drivers/mtd/nand/nand_ecc.c b/drivers/mtd/nand/nand_ecc.c index
> 868147a..6b19058 100644
> --- a/drivers/mtd/nand/nand_ecc.c
> +++ b/drivers/mtd/nand/nand_ecc.c
> @@ -429,7 +429,8 @@ int nand_correct_data(struct mtd_info *mtd, unsigned char
> *buf,
>  		      unsigned char *read_ecc, unsigned char *calc_ecc)
>  {
>  	unsigned char b0, b1, b2;
> -	unsigned char byte_addr, bit_addr;
> +	uint32_t byte_addr;
> +	unsigned char bit_addr;
>  	/* 256 or 512 bytes/ecc  */
>  	const uint32_t eccsize_mult =
>  			(((struct nand_chip *)mtd->priv)->ecc.size) >> 8;
> 

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)