From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [patch/rfc 2.6.29 1/2] MTD: driver model updates From: David Woodhouse To: Kevin Cernekee In-Reply-To: References: <200903260042.42091.david-b@pacbell.net> <1238742215.20906.99.camel@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" Date: Sat, 04 Apr 2009 15:36:37 +0100 Message-Id: <1238855797.4068.6.camel@macbook.infradead.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: David Brownell , Linux MTD , linux-kernel@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2009-04-03 at 13:00 -0700, Kevin Cernekee wrote: > Based on: http://lists.infradead.org/pipermail/linux-mtd/2009-March/025005.html > > My only change from the previous posting > (http://lists.infradead.org/pipermail/linux-mtd/2009-April/025121.html) > was to remove the "mtd_" prefix on the device attributes. > > David's 2/2 patch > (http://lists.infradead.org/pipermail/linux-mtd/2009-March/025011.html) > may still be used as-is. > > Signed-off-by: Kevin Cernekee Thanks, this looks like a very good start in the direction we need to go. I've applied David's patches as well as the changes from this one, and hooked it up for the CAFÉ NAND controller too. Since the callers are passing a struct mtd_info * into nand_scan(), it doesn't seem necessary to pass the device in too; they can just set it for themselves. Passing it in to the NOR chip probe routines might make sense though. I'm not worried about a flag day for _internal_ stuff -- for 2.6.31 I think I'm going to add a WARN_ON(&mtd->dev.parent) into the core code. I really do think I want this to avoid the need for 64-bit ioctls (except maybe MEMERASE64). -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation