public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: vimalsingh@ti.com
Cc: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: RE: [resending][PATCH] [MTD] [NAND] nand_ecc.c: Bug fix in nand ecc
Date: Fri, 24 Apr 2009 10:39:57 +0300	[thread overview]
Message-ID: <1240558797.22645.1.camel@localhost.localdomain> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739404321C6025@dbde02.ent.ti.com>

Hi,

On Fri, 2009-04-24 at 12:02 +0530, Singh, Vimal wrote:
> It looks like Frans is not active to this list, now a days...
> so can some one else review this patch:
> http://lists.infradead.org/pipermail/linux-mtd/2009-April/025094.html


It did not apply. Please, send patches which can be applied.

Please, fix you e-mail. Is your address really
"IMCEAEX-_O=TI_OU=BD_CN=RECIPIENTS_CN=X0094262@dlee86.itg.ti.com" ?

But I fixed both - your patch and your e-mail. Please, check your other
patches and re-send them if they are corrupted. Please, take a look at
Documentation/SubmittingPatches

I've amended your patch a little. Instead of using 'uint32_t', I
made it to be 'int'. I do not see any reason to limit the compiler
and CPU by 32 bits. I do not appreciate unreasonable usage of these
'uint32_t' and similar types, and I think 'int' is perfectly fine
in your case. Could you please verify this? It is here:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git?a=commit;h=e3b8cec094d12aabbfd77c462b1932537e1c239e

Thanks!

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2009-04-24  7:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01  9:53 [resending][PATCH] [MTD] [NAND] nand_ecc.c: Bug fix in nand ecc vimal singh
2009-04-01 10:01 ` Artem Bityutskiy
2009-04-01 10:02   ` Artem Bityutskiy
2009-04-01 10:11   ` Singh, Vimal
2009-04-24  6:32     ` Singh, Vimal
2009-04-24  7:39       ` Artem Bityutskiy [this message]
2009-04-24  8:27         ` Singh, Vimal
2009-04-24  9:31           ` Artem Bityutskiy
2009-04-25 14:55             ` Frans Meulenbroeks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240558797.22645.1.camel@localhost.localdomain \
    --to=dedekind@infradead.org \
    --cc=fransmeulenbroeks@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vimalsingh@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox