Re: [PATCH 1/2] mkfs.ubifs: UBI I/O Library

[Artem Bityutskiy <dedekind@infradead.org>]

On Fri, 2009-05-08 at 14:07 +0200, Corentin Chary wrote:
> No, not really, libubiio provide what you can find in ubi.h, nothing
> more (open/close/read/write/change/erase/map/unmap).
> There some code in common to read sysfs properties, it's all.
> There is libubiio_int.h with some duplicate code from
> ubi-utils/src/common.h which could be removed.
> libubi on the other hand provide functions to manipulate volume and
> devices (rename, create, etc..).

Still, what's the reason to have a separate library?
Why not to add your stuff to existing  one? If there
are some issues in libubi, they could be fixed. I just
see a lot of common code.

> But the current tree/build system make it hard to share code between
> ubi-utils/mtd-utils/mkfs. It what
> If you check, there is also three crc32.c/h in mtd-utils ...
> (See http://git.iksaif.net/?p=users/iksaif/mtd-utils.git;a=tree;hb=HEAD
> to check what a clean tree could be)

But surely you may try to re-arrange the tree, make it saner?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)