public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Alexander Clouter <alex@digriz.org.uk>
Cc: hsweeten@visionengravers.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [REPOST] mtd: extend plat_nand for (read|write)_buf
Date: Fri, 15 May 2009 16:51:00 +0300	[thread overview]
Message-ID: <1242395460.27996.249.camel@localhost.localdomain> (raw)
In-Reply-To: <20090511182801.GK32684@woodchuck>

On Mon, 2009-05-11 at 19:28 +0100, Alexander Clouter wrote:
> This patch adds (write|read)_buf callbacks to plat_nand.
> 
> The NAND on the TS-7800 provisioned by the FPGA allows readw() and 
> readl() to be used which gives a 2.5x speed up.  To be able to use this 
> from the plat_nand driver a hook for read_buf (and also write_buf whilst 
> we are in there) need to be made available.  This patch adds the hook.
> 
> This is a repost[1] of a feature asked for before[2], plus other helpful 
> patches to plat_nand[3] would be welcomed if at all possible too.
> 
> [1] http://lists.infradead.org/pipermail/linux-mtd/2009-March/024747.html
> [2] http://lists.infradead.org/pipermail/linux-mtd/2007-October/019659.html
> [3] http://lists.infradead.org/pipermail/linux-mtd/2009-March/024780.html
> 
> Signed-off-by: Alexander Clouter <alex@digriz.org.uk>

I think this should be submitted with the user at the same
time. Adding hooks without having a user is not very good.
E.g., you may find out later that this does not help, or
cancel your project, or end up with different call-backs,
etc.

You may keep this patch privately, work on your NAND driver,
and when you have it ready, you submit it with this at the
same time.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2009-05-15 13:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 18:28 [PATCH] [REPOST] mtd: extend plat_nand for (read|write)_buf Alexander Clouter
2009-05-15 13:51 ` Artem Bityutskiy [this message]
2009-05-15 15:05   ` Alexander Clouter
2009-05-15 15:27     ` Alexander Clouter
2009-05-15 15:31     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242395460.27996.249.camel@localhost.localdomain \
    --to=dedekind@infradead.org \
    --cc=alex@digriz.org.uk \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox