From: Artem Bityutskiy <dedekind@infradead.org>
To: Mika Korhonen <mika.j.korhonen@gmail.com>
Cc: David Brownell <david-b@pacbell.net>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd Mailing List <linux-mtd@lists.infradead.org>,
Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH] [MTD] ONENAND: Fix devexit macro usage in OMAP OneNAND (was Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers)
Date: Sat, 23 May 2009 12:14:39 +0300 [thread overview]
Message-ID: <1243070079.21646.24.camel@localhost.localdomain> (raw)
In-Reply-To: <7948530905211317h5bd9a395ta5b8575befed96c@mail.gmail.com>
On Thu, 2009-05-21 at 23:17 +0300, Mika Korhonen wrote:
> 2009/4/29 David Brownell <david-b@pacbell.net>:
> > On Wednesday 29 April 2009, Adrian Hunter wrote:
> >> + .shutdown = __devexit_p(omap2_onenand_shutdown),
> >
> > That looks wrong. Shutdown functions shouldn't get discarded
> > like exit functions. I'd think the fix for that would be taking
> > away any __devexit annotation on the shutdown function.
> >
> >
>
> Here follows the revised patch, fixed as suggested.
I've taken this patch to l2-mtd-2.6.git.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2009-05-23 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 20:17 [PATCH] [MTD] ONENAND: Fix devexit macro usage in OMAP OneNAND (was Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers) Mika Korhonen
2009-05-23 9:14 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243070079.21646.24.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=adrian.hunter@nokia.com \
--cc=david-b@pacbell.net \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mika.j.korhonen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox