From: Artem Bityutskiy <dedekind@infradead.org>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mkfs.ubifs: use libubi to format UBI volume
Date: Mon, 25 May 2009 11:40:16 +0300 [thread overview]
Message-ID: <1243240816.21646.102.camel@localhost.localdomain> (raw)
In-Reply-To: <71cd59b00905250123o516a293an3c5c541cc417fc94@mail.gmail.com>
On Mon, 2009-05-25 at 10:23 +0200, Corentin Chary wrote:
> On Mon, May 25, 2009 at 9:58 AM, Artem Bityutskiy
> <dedekind@infradead.org> wrote:
> >
> > I know this is nit-picking, but would be nicer to close libubi
> > in case of errors. Namely, in the second and third checks.
>
> In case of error, close_target() will close libubi. (if(ubi) libubi_close(ubi)).
> But maybe you want to explicitly close libubi here ?
Ah, OK. NP then.
> The comma is just at the 80 column limit.
> Using Lindent, we get:
> return
> sys_err_msg("bad root file-system directory '%s'",
> root);
>
> Is this ok ?
I think you may just ignore the 80 chars limit and make it 81 chars :-)
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-05-25 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 6:26 [PATCH 0/2] mkfs.ubifs updates Corentin Chary
2009-05-25 6:26 ` [PATCH 1/2] mkfs.ubifs: remove duplicated code Corentin Chary
2009-05-25 6:26 ` [PATCH 2/2] mkfs.ubifs: use libubi to format UBI volume Corentin Chary
2009-05-25 7:58 ` Artem Bityutskiy
2009-05-25 8:23 ` Corentin Chary
2009-05-25 8:40 ` Artem Bityutskiy [this message]
2009-05-26 13:08 ` [PATCH] " Corentin Chary
2009-05-27 12:21 ` Artem Bityutskiy
2009-05-27 13:19 ` Corentin Chary
2009-05-27 13:21 ` Artem Bityutskiy
2009-06-02 9:26 ` Artem Bityutskiy
2009-05-27 11:29 ` [PATCH 2/2] " Corentin Chary
2009-05-27 11:33 ` Artem Bityutskiy
2009-05-25 7:49 ` [PATCH 1/2] mkfs.ubifs: remove duplicated code Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243240816.21646.102.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox