From: Artem Bityutskiy <dedekind@infradead.org>
To: Brijesh Singh <brij.singh@samsung.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [UBI] Volume table update fix
Date: Mon, 22 Jun 2009 10:34:28 +0300 [thread overview]
Message-ID: <1245656068.9487.31.camel@localhost.localdomain> (raw)
In-Reply-To: <1245655796.9487.29.camel@localhost.localdomain>
On Mon, 2009-06-22 at 10:29 +0300, Artem Bityutskiy wrote:
> > + if (copy > 0)
> > + return 0;
> > + else
> > + return err;
> This is a tricky place, IMO, and deserves a comment. Could we have
> something like:
>
> /*
> * If the first volume table copy has been changed then overall the
> * operation has succeeded, because the change would be there if we now
> * re-attached the UBI device. Thus, return success in this case.
> */
>
This looks a bit more elegant:
/*
* If the first volume table copy has been changed then overall the
* operation has succeeded, because the change would be there if we now
* re-attached the UBI device. Thus, return success in this case.
*/
return copy ? 0 : err;
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-06-22 7:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 11:01 [PATCH] [UBI] Volume table update fix Brijesh Singh
2009-06-22 7:29 ` Artem Bityutskiy
2009-06-22 7:34 ` Artem Bityutskiy [this message]
2009-06-22 11:14 ` Brijesh Singh
2009-06-22 13:11 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245656068.9487.31.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=brij.singh@samsung.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox