Re: [PATCH][MTD][NAND]: fix omap2.c compile failure and warning

David Woodhouse
2009-06-27T07:45:59Z

On Sat, 2009-06-27 at 11:07 +0530, vimal singh wrote:
> > The 'status' you return in the case that you _have_ gone through the
> > loop is still wrong though, isn't it?
> Yes, I have corrected that in below patch. Its my bad, I did not fix it
> previously.
>
> Signed-off-by: Vimal Singh <vimalsingh at ti.com>
> Signed-off-by: Ming Lei <tom.leiming at gmail.com>

Er, did he? And please put proper email addresses in. If you can't find
an @ sign on your keyboard, cut and paste it from elsewhere.

> @@ -558,6 +560,7 @@ static int omap_wait(struct mtd_info *mtd, struct nand_chip
> status = __raw_readb(this->IO_ADDR_R);
> - if (!(status & 0x40))
> + if (status & NAND_STATUS_READY)
> break;

Hm... now you're polling the PASS/FAIL bit in the status, not the
READY/BUSY bit. I suspect that's not going to work too well...

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation