From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.nokia.com ([192.100.122.233] helo=mgw-mx06.nokia.com)
	by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux))
	id 1MMOJn-0003YP-IO
	for linux-mtd@lists.infradead.org; Thu, 02 Jul 2009 15:35:31 +0000
Subject: Re: [PATCH] ubifs: allow more than one volume to be mounted
From: Artem Bityutskiy <dedekind@infradead.org>
To: Daniel Mack <daniel@caiaq.de>
In-Reply-To: <20090702152730.GJ18340@buzzloop.caiaq.de>
References: <1246547747-13366-1-git-send-email-daniel@caiaq.de>
	<4A4CCF99.30104@gmail.com> <20090702152730.GJ18340@buzzloop.caiaq.de>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 02 Jul 2009 18:34:50 +0300
Message-Id: <1246548890.20721.23.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: Adrian Hunter <adrian.hunter@nokia.com>, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org, Artem Bityutskiy <dedekind1@gmail.com>
Reply-To: dedekind@infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Thu, 2009-07-02 at 17:27 +0200, Daniel Mack wrote:
> On Thu, Jul 02, 2009 at 06:17:45PM +0300, Artem Bityutskiy wrote:
> > Daniel Mack wrote:
> >> UBIFS uses a bdi device per volume, but does not care to hand out unique
> >> names to each of them. This causes an error when trying to mount more
> >> than one volumes.
> >>
> >> [  239.277407] kobject_add_internal failed for ubifs with -EEXIST, don't try to register things with the same name in the same directory.
> >> [  239.289618] [<c002a45c>] (unwind_backtrace+0x0/0xdc) from [<c0160628>] (kobject_add_internal+0x188/0x1b8)
> >> [  239.299445] [<c0160628>] (kobject_add_internal+0x188/0x1b8) from [<c01607d8>] (kobject_add+0x48/0x5c)
> >> [  239.308896] [<c01607d8>] (kobject_add+0x48/0x5c) from [<c019d96c>] (device_add+0xac/0x510)
> >> [  239.317392] [<c019d96c>] (device_add+0xac/0x510) from [<c019de58>] (device_create_vargs+0x70/0xa4)
> >> [  239.326589] [<c019de58>] (device_create_vargs+0x70/0xa4) from [<c0073138>] (bdi_register+0x44/0x64)
> >> [  239.335854] [<c0073138>] (bdi_register+0x44/0x64) from [<c01249f0>] (ubifs_get_sb+0x3c8/0x10cc)
> >> [  239.344769] [<c01249f0>] (ubifs_get_sb+0x3c8/0x10cc) from [<c008b054>] (vfs_kern_mount+0x50/0xa8)
> >> [  239.353867] [<c008b054>] (vfs_kern_mount+0x50/0xa8) from [<c008b0f0>] (do_kern_mount+0x34/0xd0)
> >> [  239.362799] [<c008b0f0>] (do_kern_mount+0x34/0xd0) from [<c009f7b4>] (do_mount+0x644/0x6b4)
> >> [  239.371377] [<c009f7b4>] (do_mount+0x644/0x6b4) from [<c009f8a8>] (sys_mount+0x84/0xcc)
> >> [  239.379538] [<c009f8a8>] (sys_mount+0x84/0xcc) from [<c0025e80>] (ret_fast_syscall+0x0/0x2c)
> >>
> >> Append the UBI volume and device ID to avoid that.
> >>
> >> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> >> Cc: Artem Bityutskiy <dedekind@infradead.org>
> >> Cc: Adrian Hunter <ext-adrian.hunter@nokia.com>
> >> Cc: linux-mtd@lists.infradead.org
> >
> > Thanks, I'll look at this tomorrow and try to sent it to Linus
> > ASAP.
> 
> Btw - Adrian Hunter's email in MAINTAINERS seems to be outdated:
> 
> <ext-adrian.hunter@nokia.com>: host mx1.nokia.com[192.100.122.228] said:
> 550 5.1.1 <ext-adrian.hunter@nokia.com>... User unknown (in reply to RCPT TO command)

Ok, I'll fix that too, thanks. Nowadays it is: adrian.hunter@nokia.com

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)