From: Artem Bityutskiy <dedekind@infradead.org>
To: Matthias Kaehlcke <matthias@kaehlcke.net>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org
Subject: Re: [PATCH] mtdblock: introduce mtdblks_lock
Date: Wed, 15 Jul 2009 11:39:22 +0300 [thread overview]
Message-ID: <1247647162.11353.12.camel@localhost.localdomain> (raw)
In-Reply-To: <20090715083603.GH18774@darwin>
On Wed, 2009-07-15 at 10:36 +0200, Matthias Kaehlcke wrote:
> El Wed, Jul 15, 2009 at 10:41:54AM +0300 Artem Bityutskiy ha dit:
>
> > On Tue, 2009-07-14 at 22:04 +0200, Matthias Kaehlcke wrote:
> > > +static struct mutex mtdblks_lock;
> > > +
> > > /*
> > > * Cache stuff...
> > > *
> > > @@ -270,6 +272,8 @@ static int mtdblock_open(struct mtd_blktrans_dev *mbd)
> > >
> > > DEBUG(MTD_DEBUG_LEVEL1,"mtdblock_open\n");
> > >
> > > + mutex_lock(&mtdblks_lock);
> > > +
> > > if (mtdblks[dev]) {
> > > mtdblks[dev]->count++;
> > > return 0;
> >
> > Now about unlocking the mutex here?
>
> i missed this one ...
>
> thanks for your review. i'm going fix that and send out an updated
> version of the patch
Err, I've already amended your patch and put it to my l2-mtd-2.6.git:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git?a=commit;h=2a4d4fdb6393fdcbfea546b2474baf41d434302a
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-07-15 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 20:04 [PATCH] mtdblock: introduce mtdblks_lock Matthias Kaehlcke
2009-07-15 7:41 ` Artem Bityutskiy
2009-07-15 8:36 ` Matthias Kaehlcke
2009-07-15 8:39 ` Artem Bityutskiy [this message]
2009-07-15 9:15 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247647162.11353.12.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthias@kaehlcke.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox