From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.nokia.com ([192.100.122.230] helo=mgw-mx03.nokia.com) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1MROtt-0006Tx-Go for linux-mtd@lists.infradead.org; Thu, 16 Jul 2009 11:13:26 +0000 Subject: Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c From: Artem Bityutskiy To: subrata@linux.vnet.ibm.com In-Reply-To: <1247742274.5572.8.camel@subratamodak.linux.ibm.com> References: <20090715021901.4112.45973.sendpatchset@subratamodak.linux.ibm.com> <1247640750.11353.6.camel@localhost.localdomain> <4A5E1D1A.3090705@s5r6.in-berlin.de> <1247738232.11353.90.camel@localhost.localdomain> <1247742274.5572.8.camel@subratamodak.linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 16 Jul 2009 14:12:45 +0300 Message-Id: <1247742765.11353.114.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Sachin P Sant , LKML , David Howells , Stefan Richter , linux-mtd@lists.infradead.org, Adrian Hunter , Balbir Singh Reply-To: dedekind@infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2009-07-16 at 16:34 +0530, Subrata Modak wrote: > Correct. There has been other warning fixes i have sent to LKML, where i > have tweaked the code to fix the compilation, but, code tweaking may not > be possible in this case. However , i would still investigate. I do not think that in _general_ it is a good idea to tweak code just to have gcc pleased, granted the code is correct. In this case it is more preferable to shut it up, e.g., using 'unitialized_var()'. -- Best regards, Artem Bityutskiy (Битюцкий Артём)