Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c

Stefan Richter
2009-07-15T18:16:58Z

Artem Bityutskiy wrote:
> On Wed, 2009-07-15 at 07:49 +0530, Subrata Modak wrote:
>> Following fix is inspired by David Howells fix few days back:
>> http://lkml.org/lkml/2009/7/9/109,
>>
>> Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
>> ---
>
> Removed junk comma at the end of "signed-off-by" and pushed to
> the ubifs-2.6.git tree:
>
> http://git.infradead.org/ubifs-2.6.git?a=commit;h=5c1507e6097c4abc13bbad69de137366c9043f22
>
> Thanks.
>

The changelog of the patch is bad. "Fix compilation warning" is not
correct. It should be "suppress compilation warning" or "annotate
unitialized variable" or whatever --- i.e. it should say what it does.
Furthermore, since the 3 lines context around the change in the diff do
not reveal why the chosen "fix" is correct and desirable, the changelog
should also leave a note why it's done this way.

The patch form David Howells which is quoted here has an equally bad
subject, but at least its changelog goes on to explain what the patch
really does and why it does it in the proposed way.
--
Stefan Richter
-=====-==--= -=== -====