Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c

Artem Bityutskiy
2009-07-16T12:11:50Z

On Thu, 2009-07-16 at 13:57 +0200, Stefan Richter wrote:
> Stefan Richter wrote:
> > So, is uninitialized_var() a good fix here? I'd say it's not a
> > particular good one. Count the lines of code of dbg_check_old_index()
> > and the maximum indentation level of it. Then remember the teachings of
> > CodingStyle. :-) See? dbg_check_old_index() clearly isn't a prime
> > example of best kernel coding practice. /Perhaps/ a little bit of
> > refactoring would make it easier to read, and as a bonus side effect,
> > make it unnecessary to use the slightly dangerous and
> > uninitialized_var() macro here.
>
> PS:
> On the other hand, it is debug code. Is it bound to stay in there
> forever? If not, then it's surely not worth the developer time to
> beautify it.

Yes, it is debugging code. It is doing additional consistency/sanity
checks of the internal data structures when you compile it in and enable
it. And yes, I'd like it to stay there forever, because it is a very
nice tool to catch bugs. In fact, I am really keen of this type of
debugging when you have internal checking functions. They help a lot.

--
Best regards,
Artem Bityutskiy (Битюцкий Артём)