From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.nokia.com ([192.100.105.134] helo=mgw-mx09.nokia.com) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1MRhsd-0000Q0-RV for linux-mtd@lists.infradead.org; Fri, 17 Jul 2009 07:29:24 +0000 Subject: Re: [PATCH] Clean up some extra unused arguments in fs/ubifs/ From: Artem Bityutskiy To: Subrata Modak In-Reply-To: <20090717062101.11440.49299.sendpatchset@subratamodak.linux.ibm.com> References: <20090717062101.11440.49299.sendpatchset@subratamodak.linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 17 Jul 2009 10:28:38 +0300 Message-Id: <1247815718.11353.177.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Sachin P Sant , LKML , David Howells , Stefan Richter , linux-mtd@lists.infradead.org, Adrian Hunter , Balbir Singh Reply-To: dedekind@infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2009-07-17 at 11:51 +0530, Subrata Modak wrote: > Hi, > > "const struct ubifs_info *c" exists as an extra argument for major > function definitions under the "fs/ubifs/*" code. The reason why > this extra argument exists is based on assumtion that there > will be several key schemes. It is possible to add more than one, > but we use only one. When there is practically no usage of them > presently, they can be removed, and if needed can be added later. > > The following patch does that by removing: > 1) "const struct ubifs_info *c" where it is not used/necessary, > 2) remove xent_key_init_hash() function, as it is also not used, > 3) remove data_key_init_flash() function, as it is also not used anywhere, Fine with 2 and 3. Not fine with 1, unless it makes the code smaller or more optimal. -- Best regards, Artem Bityutskiy (Битюцкий Артём)