linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: "Leo (Hao) Chen" <leochen@broadcom.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-arm-kernel@lists.arm.linux.org.uk"
	<linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH v3 26/27] [ARM] [NAND] [bcmring] add bcmring umi nand driver support
Date: Sun, 19 Jul 2009 08:08:59 +0300	[thread overview]
Message-ID: <1247980139.11353.194.camel@localhost.localdomain> (raw)
In-Reply-To: <8628FE4E7912BF47A96AE7DD7BAC0AADCB25C53608@SJEXCHCCR02.corp.ad.broadcom.com>

On Fri, 2009-07-17 at 12:13 -0700, Leo (Hao) Chen wrote:
> This patch addes bcmring umi nand driver support, with bch ecc algorithm support.
> 
> It addes header files, register files, Kconfig option and Makefile
> entry.
> 
> Signed-off-by: Leo Chen <leochen@broadcom.com>

Hi, the code neat in general, but would it be possible to amend it and
make more compatible with the Linux coding style?

See Documentation/CodingStyle
See scripts/checkpatch.pl

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2009-07-19  5:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 19:13 [PATCH v3 26/27] [ARM] [NAND] [bcmring] add bcmring umi nand driver support Leo (Hao) Chen
2009-07-19  5:08 ` Artem Bityutskiy [this message]
2009-07-19 10:56   ` Steve Chen
2009-07-21 22:46     ` Leo (Hao) Chen
2009-07-22  6:12       ` Artem Bityutskiy
2009-07-28 22:08   ` Leo (Hao) Chen
2009-07-28 22:38     ` Leo (Hao) Chen
2009-08-09  5:16       ` Artem Bityutskiy
2009-08-09  7:12         ` Scott Branden
2009-08-09  7:27           ` Artem Bityutskiy
2009-08-10 17:33             ` Scott Branden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247980139.11353.194.camel@localhost.localdomain \
    --to=dedekind@infradead.org \
    --cc=leochen@broadcom.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).