[PATCH] inappropriate pending block in foldchain

[PATCH] inappropriate pending block in foldchain

[Mohanlal Jangir]

In function  INFTL_findwriteunit, inappropriate pending block
parameter is passed which prevents 0xFFFF block copy during foldchain.
This patch fixes the problem.

-Mohan

diff -Nur a/linux-2.6.30.5/drivers/mtd/inftlcore.c
b/linux-2.6.30.5/drivers/mtd/inftlcore.c
--- a/linux-2.6.30.5/drivers/mtd/inftlcore.c 2009-08-17 06:19:38.000000000 +0900
+++ b/linux-2.6.30.5/drivers/mtd/inftlcore.c 2009-08-29 19:04:21.953125000 +0900
@@ -549,7 +549,7 @@
     * waiting to be picked up. We're going to have to fold
     * a chain to make room.
     */
-   thisEUN = INFTL_makefreeblock(inftl, 0xffff);
+   thisEUN = INFTL_makefreeblock(inftl, block);

    /*
     * Hopefully we free something, lets try again.

Re: [PATCH] inappropriate pending block in foldchain

[Artem Bityutskiy]

On Sat, 2009-08-29 at 19:17 +0900, Mohanlal Jangir wrote:
> In function  INFTL_findwriteunit, inappropriate pending block
> parameter is passed which prevents 0xFFFF block copy during foldchain.
> This patch fixes the problem.

I could not find your signed-off-by line.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: [PATCH] inappropriate pending block in foldchain

[Artem Bityutskiy]

On Sat, 2009-08-29 at 19:17 +0900, Mohanlal Jangir wrote:
> In function  INFTL_findwriteunit, inappropriate pending block
> parameter is passed which prevents 0xFFFF block copy during foldchain.
> This patch fixes the problem.
> 
> -Mohan
> 
> diff -Nur a/linux-2.6.30.5/drivers/mtd/inftlcore.c
> b/linux-2.6.30.5/drivers/mtd/inftlcore.c
> --- a/linux-2.6.30.5/drivers/mtd/inftlcore.c 2009-08-17 06:19:38.000000000 +0900
> +++ b/linux-2.6.30.5/drivers/mtd/inftlcore.c 2009-08-29 19:04:21.953125000 +0900
> @@ -549,7 +549,7 @@
>      * waiting to be picked up. We're going to have to fold
>      * a chain to make room.
>      */
> -   thisEUN = INFTL_makefreeblock(inftl, 0xffff);
> +   thisEUN = INFTL_makefreeblock(inftl, block);

I cannot apply your patch. Please, send the patch to yourself first,
make sure you can save it and apply using 'git am', and when it works,
send it to the mailing list.

Hint: we use "git format-patch" to create patches.

Thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

[PATCH] inappropriate pending block in foldchain

[Mohan Lal Jangir]

Signed-off-by: Mohan Lal Jangir <mohanlaljangir@gmail.com>
---
 drivers/mtd/inftlcore.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 mode change 100644 => 100755 drivers/mtd/inftlcore.c

diff --git a/drivers/mtd/inftlcore.c b/drivers/mtd/inftlcore.c
old mode 100644
new mode 100755
index d8cf29c..8aca552
--- a/drivers/mtd/inftlcore.c
+++ b/drivers/mtd/inftlcore.c
@@ -550,7 +550,7 @@ hitused:
 			 * waiting to be picked up. We're going to have to fold
 			 * a chain to make room.
 			 */
-			thisEUN = INFTL_makefreeblock(inftl, BLOCK_NIL);
+			thisEUN = INFTL_makefreeblock(inftl, block);

 			/*
 			 * Hopefully we free something, lets try again.
-- 
1.6.1.2

Re: [PATCH] inappropriate pending block in foldchain

[Mohanlal Jangir]

> Hint: we use "git format-patch" to create patches.
>

I hope, my struggle with git has yielded something acceptable :)

>From 736fe41b3a8f42f72f793f6a18fcfa420abc6b7b Mon Sep 17 00:00:00 2001
From: Mohan Lal Jangir <mohanlaljangir@gmail.com>
Date: Thu, 3 Sep 2009 22:38:53 +0900
Subject: [PATCH] inappropriate pending block in foldchain


Signed-off-by: Mohan Lal Jangir <mohanlaljangir@gmail.com>
---
 drivers/mtd/inftlcore.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 mode change 100644 => 100755 drivers/mtd/inftlcore.c

diff --git a/drivers/mtd/inftlcore.c b/drivers/mtd/inftlcore.c
old mode 100644
new mode 100755
index d8cf29c..8aca552
--- a/drivers/mtd/inftlcore.c
+++ b/drivers/mtd/inftlcore.c
@@ -550,7 +550,7 @@ hitused:
 			 * waiting to be picked up. We're going to have to fold
 			 * a chain to make room.
 			 */
-			thisEUN = INFTL_makefreeblock(inftl, BLOCK_NIL);
+			thisEUN = INFTL_makefreeblock(inftl, block);

 			/*
 			 * Hopefully we free something, lets try again.
-- 
1.6.1.2