From: David Woodhouse <dwmw2@infradead.org>
To: Victor Gallardo <vgallardo@amcc.com>
Cc: Prodyut Hazarika <phazarika@amcc.com>,
linux-mtd@lists.infradead.org, Feng Kan <fkan@amcc.com>
Subject: RE: [PATCH] [JFFS2] Fix csize integer overflow issue due to truncation
Date: Sun, 20 Sep 2009 05:33:42 -0700 [thread overview]
Message-ID: <1253450032.6317.89.camel@macbook.infradead.org> (raw)
In-Reply-To: <0CA0A16855646F4FA96D25A158E299D606FFE631@SDCEXCHANGE01.ad.amcc.com>
On Sat, 2009-09-19 at 22:57 -0700, Victor Gallardo wrote:
> Hi David,
>
> I don't have access to a system till Monday. I'll give it a try then.
Thanks.
> Overall the patch looks good to me, except this line.
>
> > +#define tn_overlapped(tn) (!!(((tn)->__csize) & TN_OVERLAP))
>
> Should just be this.
>
> #define tn_overlapped(tn) ((tn)->__csize) & TN_OVERLAP)
You object to the !! ?
That was intentional. Sometimes we print the value of tn_overlapped(),
and I wanted it to be 1, not a huge number.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-09-20 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <25217471.1985431251223831787.JavaMail.nabble@isper.nabble.com>
2009-08-27 23:37 ` [PATCH] [JFFS2] Fix csize integer overflow issue due to truncation Victor Gallardo
2009-08-28 5:18 ` Artem Bityutskiy
2009-08-28 13:52 ` Victor Gallardo
2009-09-19 20:40 ` David Woodhouse
2009-09-19 21:05 ` David Woodhouse
2009-09-20 5:57 ` Victor Gallardo
2009-09-20 12:33 ` David Woodhouse [this message]
2009-09-20 13:40 ` Victor Gallardo
2009-09-22 22:55 ` Victor Gallardo
2009-08-21 22:43 Victor Gallardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253450032.6317.89.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=fkan@amcc.com \
--cc=linux-mtd@lists.infradead.org \
--cc=phazarika@amcc.com \
--cc=vgallardo@amcc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox