From: David Woodhouse <dwmw2@infradead.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [MTD] [CHIPS] stm_flash: new ST PSD4256G compatible flash chip driver
Date: Tue, 22 Sep 2009 16:20:50 -0700 [thread overview]
Message-ID: <1253661650.27055.494.camel@macbook.infradead.org> (raw)
In-Reply-To: <8bd0f97a0909221605j1f4a0d62m5707e0ad11c7ece4@mail.gmail.com>
On Tue, 2009-09-22 at 19:05 -0400, Mike Frysinger wrote:
>
> the only problem i have here is with the need to 0xff pad the mfr/dev
> id's. any idea what's up with that ? the device is 16bit and i set
> my .width in my board resources to 2, but the id field is only 8bit,
> so in 16bit mode the id is padded with 0xff instead of 0x00.
Hm, odd -- but I wouldn't lose sleep over it.
However, the datasheet suggests that the high byte is unspecified. Could
it be returning the value of the flash data at that location, rather
than a constant 0xFF? If so, we'd need to add a flag to the jedec match
table to make it match only the low byte?
Or maybe I'd make you do your own probe in that case, rather than
polluting jedec_probe.c... :)
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-09-22 23:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 10:59 [PATCH] [MTD] [CHIPS] stm_flash: new ST PSD4256G compatible flash chip driver Mike Frysinger
2009-09-19 20:08 ` David Woodhouse
2009-09-19 20:28 ` Mike Frysinger
2009-09-19 21:01 ` David Woodhouse
2009-09-22 23:05 ` Mike Frysinger
2009-09-22 23:20 ` David Woodhouse [this message]
2009-09-22 23:30 ` Mike Frysinger
2009-09-22 23:39 ` David Woodhouse
2009-09-23 4:49 ` [PATCH] mtd: jedec_probe: add PSD4256G6V id Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253661650.27055.494.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox