From: Artem Bityutskiy <dedekind1@gmail.com>
To: Amul Kumar Saha <amul.saha@samsung.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Kyungmin Park <kmpark@infradead.org>,
linux-mtd@lists.infradead.org, adrian.hunter@nokia.com
Subject: Re: [PATCH] [OneNAND] OTP support re-implementation 1/1
Date: Mon, 28 Sep 2009 12:38:48 +0300 [thread overview]
Message-ID: <1254130728.3778.57.camel@localhost> (raw)
In-Reply-To: <E902C77C74C544A3A554DD9881742C04@sisodomain.com>
On Mon, 2009-09-07 at 15:15 +0530, Amul Kumar Saha wrote:
> What is OTP in OneNAND?
> The device includes,
> 1. one block-sized OTP (One Time Programmable) area and
> 2. user-controlled 1st block OTP(Block 0)
> that can be used to increase system security or to provide identification capabilities.
>
Could you please refresh your patch and resend it? The old one does not
apply anymore.
Also, could you please avoid doing these:
printk(KERN_ERR "onenand_write_ops_nolock: \
write failed %d\n", ret);
function name prints. This is bad practice. You could amend whole
onenand_base.c first, then send the OTP re-write as a follow up patch.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-09-28 9:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 10:43 [PATCH] [OneNAND] OTP support re-implementation 1/1 Amul Kumar Saha
2009-08-26 5:41 ` Amul Kumar Saha
2009-08-26 5:58 ` Artem Bityutskiy
2009-08-27 6:37 ` Amul Kumar Saha
2009-08-28 13:38 ` Artem Bityutskiy
2009-08-31 9:19 ` Amul Kumar Saha
2009-08-31 9:34 ` Kyungmin Park
2009-09-02 5:55 ` Amul Kumar Saha
2009-09-02 5:59 ` Amul Kumar Saha
2009-09-02 6:10 ` Artem Bityutskiy
2009-09-03 5:51 ` Amul Kumar Saha
2009-09-03 6:10 ` Artem Bityutskiy
2009-09-03 10:37 ` Amul Kumar Saha
2009-09-03 11:19 ` Artem Bityutskiy
2009-09-07 9:45 ` Amul Kumar Saha
2009-09-07 9:57 ` Kyungmin Park
2009-09-16 3:33 ` Amul Kumar Saha
2009-09-16 6:40 ` Artem Bityutskiy
2009-09-28 9:38 ` Artem Bityutskiy [this message]
2009-10-01 6:48 ` Amul Kumar Saha
2009-10-12 4:42 ` Amul Kumar Saha
-- strict thread matches above, loose matches on Subject: below --
2009-10-12 6:01 Amul Kumar Saha
2009-10-20 8:56 ` Artem Bityutskiy
2009-10-20 14:13 ` Adrian Hunter
2009-10-21 11:20 ` Amul Kumar Saha
2009-10-23 6:11 ` Artem Bityutskiy
2009-10-21 11:30 ` Amul Kumar Saha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254130728.3778.57.camel@localhost \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=amul.saha@samsung.com \
--cc=dwmw2@infradead.org \
--cc=kmpark@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox