Re: [PATCH 2/3]: mtdoops: Use panic_write if panic_on_oops is set

Simon Kagstrom
2009-10-12T06:23:20Z

On Sun, 11 Oct 2009 09:00:20 +0300
Artem Bityutskiy <dedekind1@gmail.com> wrote:

> On Thu, 2009-10-08 at 08:28 +0300, Artem Bityutskiy wrote:
>
> > > - if (mtd->panic_write && in_interrupt())
> > > + if (mtd->panic_write && (in_interrupt() || panic_on_oops))
> > > /* Interrupt context, we're going to panic so try and log */
> > > mtdoops_write(cxt, 1);
>
> Oh, panic_on_oops is not exported. So we should either export it or make
> mtdoops to be always compiled-in.

Yep, in the earlier patch series (this one!) I made it always
compiled-in, but for new one I kept the module support and also sent
a patch to LKML which exports panic_on_oops. I saw you did the same
thing now, thanks!

// Simon