From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.nokia.com ([192.100.122.233] helo=mgw-mx06.nokia.com) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1MwwYV-0000yt-Ja for linux-mtd@lists.infradead.org; Sun, 11 Oct 2009 11:25:43 +0000 Subject: Re: [PATCH 0/2] Revised: MTD: OneNAND: multiblock erase support From: Artem Bityutskiy To: Mika Korhonen In-Reply-To: <1254819360-17191-1-git-send-email-ext-mika.2.korhonen@nokia.com> References: <1254819360-17191-1-git-send-email-ext-mika.2.korhonen@nokia.com> Content-Type: text/plain; charset="UTF-8" Date: Sun, 11 Oct 2009 14:25:31 +0300 Message-Id: <1255260331.16942.37.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: amul.saha@samsung.com, kyungmin.park@samsung.com, linux-mtd@lists.infradead.org, adrian.hunter@nokia.com Reply-To: Artem.Bityutskiy@nokia.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2009-10-06 at 11:55 +0300, Mika Korhonen wrote: > This patch series is a reworked version of > > http://lists.infradead.org/pipermail/linux-mtd/2009-September/027138.html > http://lists.infradead.org/pipermail/linux-mtd/2009-September/027139.html > http://lists.infradead.org/pipermail/linux-mtd/2009-September/027140.html > > based on comments by Adrian Hunter and Kyungmin Park. This version should > address the issues pointed out by them and apply on the current mtd tree. > > The original patch is: > http://lists.infradead.org/pipermail/linux-mtd/2009-June/026130.html > > I split the original patch in two for readability: the first part extracts > the execution of erase command to a separate function for easier integration > of different erase method. The second part implements the multiblock erase > function in case multiple blocks are requested to be erased and the chip is > not Flex. > > This is useful for flashing applications that need to do their work as > fast as possible. For full 64 eraseblock case the erase speed is up to 30x > faster. (Samsung: 64 MB/s vs 2.1 GB/s, I got 1.4 GB/s on Linux kernel) Mika, I've tried to apply your patches to my tree, but they do not apply any more because of recent printk cleanups: http://git.infradead.org/mtd-2.6.git/commit/297758f8fc4e92b1915d2f5f2f84cedfe8941e5a Could you please refresh your patches against the current MTD tree and re-send? -- Best Regards, Artem Bityutskiy (Артём Битюцкий)