Re: [PATCH] MTD: Add nand_ecc test module

Artem Bityutskiy
2009-10-15T06:36:30Z

On Thu, 2009-10-15 at 10:35 +0530, vimal singh wrote:
> On Wed, Oct 14, 2009 at 9:11 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Tue, 2009-10-13 at 18:58 +0900, Akinobu Mita wrote:
> >> > This should not be needed. MTD tests are always compiled as modules,
> >> > so you should not have copilation errors. And if MTD NAND support is
> >> > not present, modprobe will just fail.
> >>
> >> nand_calculate_ecc and nand_correct_data needs CONFIG_MTD_NAND=y|m,
> >> otherwise it will get link error:
> >>
> >> ERROR: "__nand_correct_data" [drivers/mtd/tests/nand_ecc-test.ko] undefined!
> >> ERROR: "__nand_calculate_ecc" [drivers/mtd/tests/nand_ecc-test.ko] undefined!
> >
> > How about splitting tests on 2 parts - one part which does not require
> > NAND, and one which does, and make the second part compile only if NAND
> > is enabled ("depends" operator in Kconfig) ?
>
> I thought purpose of this test was to test correctness of
> 'nand_calculate_ecc' and 'nand_correct_data' functions (i.e. algos),
> which are only compiled and available when NAND is enabled.

That is exactly what I meant as well.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)