From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] MTD: Add nand_ecc test module From: Artem Bityutskiy To: vimal singh In-Reply-To: References: <1255082095-22158-1-git-send-email-akinobu.mita@gmail.com> <1255268381.16942.74.camel@localhost> <20091013095836.GA3166@localhost.localdomain> <1255534912.32489.172.camel@localhost> Content-Type: text/plain; charset="UTF-8" Date: Thu, 15 Oct 2009 09:36:30 +0300 Message-Id: <1255588590.32489.209.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org, David Woodhouse , Akinobu Mita Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2009-10-15 at 10:35 +0530, vimal singh wrote: > On Wed, Oct 14, 2009 at 9:11 PM, Artem Bityutskiy wrote: > > On Tue, 2009-10-13 at 18:58 +0900, Akinobu Mita wrote: > >> > This should not be needed. MTD tests are always compiled as modules, > >> > so you should not have copilation errors. And if MTD NAND support is > >> > not present, modprobe will just fail. > >> > >> nand_calculate_ecc and nand_correct_data needs CONFIG_MTD_NAND=y|m, > >> otherwise it will get link error: > >> > >> ERROR: "__nand_correct_data" [drivers/mtd/tests/nand_ecc-test.ko] undefined! > >> ERROR: "__nand_calculate_ecc" [drivers/mtd/tests/nand_ecc-test.ko] undefined! > > > > How about splitting tests on 2 parts - one part which does not require > > NAND, and one which does, and make the second part compile only if NAND > > is enabled ("depends" operator in Kconfig) ? > > I thought purpose of this test was to test correctness of > 'nand_calculate_ecc' and 'nand_correct_data' functions (i.e. algos), > which are only compiled and available when NAND is enabled. That is exactly what I meant as well. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)