From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 14/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (misc drivers) From: Artem Bityutskiy To: Alan Cox , "'David Woodhouse'" In-Reply-To: <20091026101909.271c109e@lxorguk.ukuu.org.uk> References: <20091024194219.GA19546@comet.dominikbrodowski.net> <1256413386-20501-14-git-send-email-linux@dominikbrodowski.net> <1256539331.29885.360.camel@localhost> <20091026071352.GA26980@isilmar.linta.de> <1256541991.29885.376.camel@localhost> <20091026101909.271c109e@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset="UTF-8" Date: Mon, 26 Oct 2009 12:18:57 +0200 Message-Id: <1256552337.29885.419.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-pcmcia@lists.infradead.org, linux-mtd , linux-usb@vger.kernel.org, Dominik Brodowski Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2009-10-26 at 10:19 +0000, Alan Cox wrote: > > > No, I don't have all that much PCMCIA hardware -- and specifically none for > > > the drivers which were modified in this patch (parport, ixj-telephony, > > > sl811; pcmcia_mtd is marked broken anyway). > > > > This driver is old and ugly, and it is even possible that no one uses it > > anymore, so I guess getting clean-ups without testing is ok for it. > > However, in that case the clean-up patches should be reviewable, which I > > wouldn't say about your patch :-) > > > > Could you please split it on several smaller patches, each doing one > > thing only? > > pcmcia_mtd has been marked broken for how long - better to delete it ? > It's in the git history if anyone ever wants to resurrect it. I do not have objections. David? -- Best Regards, Artem Bityutskiy (Артём Битюцкий)