Re: [PATCH] mtd: add lock fixup for AT49BV640D and AT49BV640DT chips

[Artem Bityutskiy <dedekind1@gmail.com>]

On Thu, 2009-10-29 at 13:05 +0100, Hans-Christian Egtvedt wrote:
> This patch sets the MTD_POWERUP_LOCK flag for AT49BV640D and AT49BV640DT
> devices, since the devices are locked when powered up and needs to be unlocked
> before interfaced.
> 
> Quote datasheet; "At power-up and reset, all sectors have their Softlock
> protection mode enabled.".
> 
> Tested on AVR32 hardware platform with an AT49BV640D flash device.
> 
> Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
> ---
>  drivers/mtd/chips/cfi_cmdset_0001.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
> index e7563a9..6228115 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0001.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0001.c
> @@ -52,6 +52,7 @@
>  #define M50FLW080A	0x0080
>  #define M50FLW080B	0x0081
>  #define AT49BV640D	0x02de
> +#define AT49BV640DT	0x02db
>  
>  static int cfi_intelext_read (struct mtd_info *, loff_t, size_t, size_t *, u_char *);
>  static int cfi_intelext_write_words(struct mtd_info *, loff_t, size_t, size_t *, const u_char *);
> @@ -255,6 +256,11 @@ static void fixup_use_point(struct mtd_info *mtd, void *param)
>  	}
>  }
>  
> +static void fixup_use_at49bv640dx_lock(struct mtd_info *mtd, void *param)
> +{
> +	mtd->flags |= MTD_POWERUP_LOCK;
> +}
> +
>  static void fixup_use_write_buffers(struct mtd_info *mtd, void *param)
>  {
>  	struct map_info *map = mtd->priv;
> @@ -313,6 +319,8 @@ static struct cfi_fixup fixup_table[] = {
>  	 * we know that is the case.
>  	 */
>  	{ CFI_MFR_ANY, CFI_ID_ANY, fixup_use_point, NULL },
> +	{ CFI_MFR_ATMEL, AT49BV640D, fixup_use_at49bv640dx_lock, NULL },
> +	{ CFI_MFR_ATMEL, AT49BV640DT, fixup_use_at49bv640dx_lock, NULL },
>  	{ 0, 0, NULL, NULL }
>  };

Why you add this to the fixup_table, not cfi_fixup_table?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)