* [PATCH] jffs2: Fix error return in jffs2_do_read_inode_internal()
@ 2009-11-12 17:09 Roel Kluin
2009-11-13 8:39 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-11-12 17:09 UTC (permalink / raw)
To: David Woodhouse, linux-mtd, Andrew Morton, LKML
The returned error should stay negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
fs/jffs2/readinode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
index 1a80301..9c26738 100644
--- a/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -1284,7 +1284,7 @@ static int jffs2_do_read_inode_internal(struct jffs2_sb_info *c,
f->target = NULL;
mutex_unlock(&f->sem);
jffs2_do_clear_inode(c, f);
- return -ret;
+ return ret;
}
f->target[je32_to_cpu(latest_node->csize)] = '\0';
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] jffs2: Fix error return in jffs2_do_read_inode_internal()
2009-11-12 17:09 [PATCH] jffs2: Fix error return in jffs2_do_read_inode_internal() Roel Kluin
@ 2009-11-13 8:39 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2009-11-13 8:39 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-mtd, Andrew Morton, David Woodhouse, LKML
On Thu, 2009-11-12 at 18:09 +0100, Roel Kluin wrote:
> The returned error should stay negative
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> fs/jffs2/readinode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Taken to my l2-mtd-2.6 tree, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-13 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-12 17:09 [PATCH] jffs2: Fix error return in jffs2_do_read_inode_internal() Roel Kluin
2009-11-13 8:39 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).