From: Richard Weinberger <richard@nod.at>
To: Martin Kurbanov <mmkurbanov@salutedevices.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Christian Brauner <brauner@kernel.org>,
Dave Chinner <dchinner@redhat.com>, Yu Zhe <yuzhe@nfschina.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
kernel@sberdevices.ru
Subject: Re: [PATCH v1 2/2] jffs2: make cleanmarker support option
Date: Thu, 19 Oct 2023 10:12:14 +0200 (CEST) [thread overview]
Message-ID: <1258129392.18842.1697703134703.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20231019073838.17586-3-mmkurbanov@salutedevices.com>
Martin,
----- Ursprüngliche Mail -----
> Von: "Martin Kurbanov" <mmkurbanov@salutedevices.com>
> This patch support for disable cleanmarker option. This is useful on
> some NAND devices which entire OOB area is protected by ECC. Problem
> fires when JFFS2 driver writes cleanmarker to some page and later it
> tries to write to this page - write will be done successfully, but after
> that such page becomes unreadable due to invalid ECC codes. This occurs
> because the second write necessitates an update to ECC, but it is
> impossible to do it correctly without block erase.
Hmm, I miss an explanation why this change is correct and safe.
You explain why the OOB area can't be used, okay. But you need to
add more details on why you change is safe in terms of filesystem
consistency.
Beside of that, I don't think this should be kernel config option.
Why not a mount option?
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-10-19 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 7:38 [PATCH v1 0/2] jffs2: make cleanmarker support option Martin Kurbanov
2023-10-19 7:38 ` [PATCH v1 1/2] jffs2: introduce jffs2_nandflash() Martin Kurbanov
2023-10-19 7:38 ` [PATCH v1 2/2] jffs2: make cleanmarker support option Martin Kurbanov
2023-10-19 8:12 ` Richard Weinberger [this message]
2023-10-23 14:54 ` Martin Kurbanov
2023-10-23 17:44 ` Richard Weinberger
2023-10-24 13:29 ` Martin Kurbanov
2023-10-23 17:55 ` David Woodhouse
2023-10-25 14:53 ` Martin Kurbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258129392.18842.1697703134703.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=dwmw2@infradead.org \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mmkurbanov@salutedevices.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox