From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.nokia.com ([192.100.122.230] helo=mgw-mx03.nokia.com)
	by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux))
	id 1NCrvf-0002uq-G4
	for linux-mtd@lists.infradead.org; Tue, 24 Nov 2009 09:43:28 +0000
Subject: Re: [PATCH] enable erase-suspend-program for CFI cmdset_0002
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
In-Reply-To: <4B0BA26F.2020707@aimvalley.nl>
References: <200911191101.nAJB1wwH000784@linpc062.aimsys.nl>
	<alpine.LFD.2.00.0911221243070.2059@xanadu.home>
	<4B0BA26F.2020707@aimvalley.nl>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 24 Nov 2009 11:42:53 +0200
Message-Id: <1259055773.18407.69.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: linux-mtd@lists.infradead.org, Nicolas Pitre <nico@fluxnic.net>
Reply-To: dedekind1@gmail.com
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Tue, 2009-11-24 at 10:07 +0100, Norbert van Bolhuis wrote:
> Nicolas Pitre wrote:
> > On Thu, 19 Nov 2009, Norbert van Bolhuis wrote:
> > 
> >> erase-suspend for writing is required to avoid blocking applications that wish
> >> to write some data (to a NOR block other than the one being erased).
> >> Particularly, it solves some huge delays that an application (which writes to a
> >> UBIFS) will experience if UBI attaches to empty NOR flash. In this case the
> >> UBI background thread will erase a lot of blocks and the application can be blocked
> >> for minutes because of the "MTD/CFI chip lock".
> >> This feature has been disabled for years. Maybe this was because the old code
> >> turned it on for erase-suspend read-only chips also (cfip->EraseSuspend & 0x1).
> >> This is wrong and corrected now.
> >> I tested this patch and it seems to work fine.
> >>
> >> Signed-off-by: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
> > 
> > FYI: I have no experience with non-Intel parts and no good knowledge of 
> > the cmdset_0002 code.  So I can't review this.
> > 
> 
> OK.
> 
> so, who's approving/reviewing patches for cmdset_0002. Nobody ?

I think we can just take it, since you tested it and confirm it works
and solves a real problem. I'll put it to my l2 tree later, do not have
time right now.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)