public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
Cc: nico@cam.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] enable erase-suspend-program for CFI cmdset_0002
Date: Tue, 24 Nov 2009 16:36:46 +0200	[thread overview]
Message-ID: <1259073406.29118.17.camel@localhost> (raw)
In-Reply-To: <200911191101.nAJB1wwH000784@linpc062.aimsys.nl>

On Thu, 2009-11-19 at 12:01 +0100, Norbert van Bolhuis wrote:
> erase-suspend for writing is required to avoid blocking applications that wish
> to write some data (to a NOR block other than the one being erased).
> Particularly, it solves some huge delays that an application (which writes to a
> UBIFS) will experience if UBI attaches to empty NOR flash. In this case the
> UBI background thread will erase a lot of blocks and the application can be blocked
> for minutes because of the "MTD/CFI chip lock".
> This feature has been disabled for years. Maybe this was because the old code
> turned it on for erase-suspend read-only chips also (cfip->EraseSuspend & 0x1).
> This is wrong and corrected now.
> I tested this patch and it seems to work fine.
> 
> Signed-off-by: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>

I did not follow the patch conversation too closely - but should you be
the patch author or Joakim? If you took it as it is - then it is Joakim.
If you modified it, then at least Joakim's name should be in the commit
log.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

  parent reply	other threads:[~2009-11-24 14:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 11:01 [PATCH] enable erase-suspend-program for CFI cmdset_0002 Norbert van Bolhuis
2009-11-22 17:45 ` Nicolas Pitre
2009-11-24  9:07   ` Norbert van Bolhuis
2009-11-24  9:42     ` Artem Bityutskiy
2009-11-24 14:36 ` Artem Bityutskiy [this message]
2009-11-24 15:12   ` Norbert van Bolhuis
2009-11-24 15:15     ` Artem Bityutskiy
2009-11-24 15:20       ` Norbert van Bolhuis
2009-11-24 15:26         ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259073406.29118.17.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nico@cam.org \
    --cc=nvbolhuis@aimvalley.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox