[PATCH/RFC v5 0/5]: mtdoops: fixes and improvements

Simon Kagstrom
2009-10-13T13:18:02Z

Hi!

Here are a couple of patches to mtdoops which I've been working on for
a while and which were recently discussed on the MTD list. They are
applied on top of Artems tree,

http://git.infradead.org/users/dedekind/l2-mtd-2.6.git

which apart from the mainline tree contains a panic fix from Aaro and
Artems mtdoops style cleanup patch.

Now, I'd like to warn sensitive readers that patch 5 *does* contain work
queue elements. However, I believe there is a good reason for this: The
mtd->write call is not good to call while oopsing, and mtd->panic_write
is sort of a last resort. Now, if we panic anyhow, mtd->panic_write
will be called, so the oops will still be written and the scheduled
work won't run anyway.

The patches are:

1. Avoid erasing already empty areas (the area would be erased at each
module load otherwise)

2. Keep track of mtdoops page cleanliness in an array. This allows
mtdoops_inc_counter to be called during panic (which fails in my
case with the current code in mtd->read, although I believe this is
MTD-driver dependent).

3. Make page size configurable to support longer messages. Mainly
needed for patch 3, but also allows longer messages to be stored
during panics (when the next oops area cannot be erased).

4. (kernel/printk.c) Add a dump_device as per Linus suggestion which
includes a dump_kmsg function which dumps the kernel log buffer to
registered devices.

5. Refactor mtdoops as a dump_device device instead of a console device.

ChangeLog:

v2:
* Patches have been reordered to keep the least controversial (?) first.
* Implement Artems suggestion to keep cleanliness in an array
* Use Aaros patch to fix the panic_on_oops problem

v3:
* Correct checkpatch issues

v4: Review corrections
* Rebase on top of "[PATCH] mtd: mtdoops: several minor cleanups"
* Patch 1 has been added
* Use 1 bit per oops page, and rename clean/dirty unused/used
* Don't initialize oops_page_dirty (it's a global structure anyway so
it will be cleared together with the rest of BSS)
* Rename mtdoops_page_size record_size (although only for the page
size setting)

v5: Corrections after panic_on_oops discussion
* Add dump_device
* Refactor mtdoops as a dump device.