Re: [PATCH 2/6] mtd: Use get_mtd_device_nm() to find named device in get_sb_mtd()

Artem Bityutskiy
2010-01-10T10:21:18Z

On Tue, 2010-01-05 at 15:20 +0000, Ben Hutchings wrote:
> This removes the need to know the number of MTD devices.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> drivers/mtd/mtdsuper.c | 18 ++++++------------
> 1 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c
> index af8b42e..d257052 100644
> --- a/drivers/mtd/mtdsuper.c
> +++ b/drivers/mtd/mtdsuper.c
> @@ -150,18 +150,12 @@ int get_sb_mtd(struct file_system_type *fs_type, int flags,
> DEBUG(1, "MTDSB: mtd:%%s, name \"%s\"\n",
> dev_name + 4);
>
> - for (mtdnr = 0; mtdnr < MAX_MTD_DEVICES; mtdnr++) {
> - mtd = get_mtd_device(NULL, mtdnr);
> - if (!IS_ERR(mtd)) {
> - if (!strcmp(mtd->name, dev_name + 4))
> - return get_sb_mtd_aux(
> - fs_type, flags,
> - dev_name, data, mtd,
> - fill_super, mnt);
> -
> - put_mtd_device(mtd);
> - }
> - }
> + mtd = get_mtd_device_nm(dev_name + 4);
> + if (!IS_ERR(mtd))
> + return get_sb_mtd_aux(
> + fs_type, flags,
> + dev_name, data, mtd,
> + fill_super, mnt);

Since now your indentation level is less, you could de-uglify the
'get_sb_mtd_aux()' as well, while you are on it. But this is minor.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)