public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Alex Dubov <oakad@yahoo.com>, joern <joern@logfs.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 3/4] MTD: blkdevs: make hotplug work
Date: Fri, 22 Jan 2010 17:59:34 +0200	[thread overview]
Message-ID: <1264175974.4494.4.camel@localhost> (raw)
In-Reply-To: <1264174506.24012.21.camel@maxim-laptop>

On Fri, 2010-01-22 at 17:35 +0200, Maxim Levitsky wrote:
> >From 368127067f4d39ba89096e4a5cb3be2dee361bad Mon Sep 17 00:00:00 2001
> From: Maxim Levitsky <maximlevitsky@gmail.com>
> Date: Fri, 22 Jan 2010 15:00:55 +0200
> Subject: [PATCH 3/4] MTD: blkdevs: make hotplug work
> 
> This changes the blkdev common module for translation layers
> to survive when underlying mtd device disappears.
> 
> To do so the following conceptual changes were made:
> 
> * disk queue and thread are now one per mtd device
>  This was it is easy to flush and destroy the queue
> 
> * the struct mtd_blktrans_dev will now be freed automaticly when last user
>  of the device quits.
>  All existing translation layers are adjusted
> 
> * ->open and release function of the translation layer will never be called
>  twise or more in the row.
>  This makes code simplier.
>  Also the ->release will be called just before mtd device disappears
>  This and above is the only visable changes on the outside.
> 
> Tested with mtdblock, ssfdc and my own sm_ftl on top of physicly hotplugable
> nand card.
> 
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>

I'll try to find some time to review this later - I'm really busy
lately. But please, split this huge patch on smaller pieces - this will
help the reviewers a lot.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

  reply	other threads:[~2010-01-22 16:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 15:31 [PATCH 0/4] Cleanups for mtd translation layer Maxim Levitsky
2010-01-22 15:33 ` [PATCH 1/4] MTD: call remove notifiers before removing the device Maxim Levitsky
2010-01-22 15:34 ` [PATCH 2/4] MTD: create lockless versions of {get,put}_mtd_device Maxim Levitsky
2010-01-22 15:35 ` [PATCH 3/4] MTD: blkdevs: make hotplug work Maxim Levitsky
2010-01-22 15:59   ` Artem Bityutskiy [this message]
2010-01-22 21:51     ` Maxim Levitsky
2010-01-22 15:36 ` [PATCH 4/4] MTD: make mtdtrans thread freezeable Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264175974.4494.4.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=joern@logfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=maximlevitsky@gmail.com \
    --cc=oakad@yahoo.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox