From: Ben Hutchings <bhutchings@solarflare.com>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-net-drivers@solarflare.com,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCHv2 3/7] nandsim: Define CONFIG_NANDSIM_MAX_PARTS and use it instead of MAX_MTD_DEVICES
Date: Thu, 28 Jan 2010 16:22:21 +0000 [thread overview]
Message-ID: <1264695741.2783.6.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <1264695182.1973.149.camel@localhost>
On Thu, 2010-01-28 at 18:13 +0200, Artem Bityutskiy wrote:
> On Tue, 2010-01-12 at 23:08 +0000, Ben Hutchings wrote:
> > MAX_MTD_DEVICES is about to be removed.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > ---
> > drivers/mtd/nand/nandsim.c | 7 +++++--
> > 1 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> > index 7281000..58c255e 100644
> > --- a/drivers/mtd/nand/nandsim.c
> > +++ b/drivers/mtd/nand/nandsim.c
> > @@ -80,6 +80,9 @@
> > #ifndef CONFIG_NANDSIM_DBG
> > #define CONFIG_NANDSIM_DBG 0
> > #endif
> > +#ifndef CONFIG_NANDSIM_MAX_PARTS
> > +#define CONFIG_NANDSIM_MAX_PARTS 32
> > +#endif
>
> Since this is not a Kconfig option, please, remove the CONFIG_ prefix.
While I understand that CONFIG_* should be reserved to Kconfig, this is
consistent with the existing build-time options in this file.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-01-28 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 23:08 [PATCHv2 3/7] nandsim: Define CONFIG_NANDSIM_MAX_PARTS and use it instead of MAX_MTD_DEVICES Ben Hutchings
2010-01-28 16:13 ` Artem Bityutskiy
2010-01-28 16:22 ` Ben Hutchings [this message]
2010-01-28 16:38 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264695741.2783.6.camel@achroite.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-net-drivers@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox