Re: [PATCHv2 3/7] nandsim: Define CONFIG_NANDSIM_MAX_PARTS and use it instead of MAX_MTD_DEVICES

[Artem Bityutskiy <dedekind1@gmail.com>]

On Thu, 2010-01-28 at 16:22 +0000, Ben Hutchings wrote:
> On Thu, 2010-01-28 at 18:13 +0200, Artem Bityutskiy wrote:
> > On Tue, 2010-01-12 at 23:08 +0000, Ben Hutchings wrote:
> > > MAX_MTD_DEVICES is about to be removed.
> > > 
> > > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > > ---
> > >  drivers/mtd/nand/nandsim.c |    7 +++++--
> > >  1 files changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> > > index 7281000..58c255e 100644
> > > --- a/drivers/mtd/nand/nandsim.c
> > > +++ b/drivers/mtd/nand/nandsim.c
> > > @@ -80,6 +80,9 @@
> > >  #ifndef CONFIG_NANDSIM_DBG
> > >  #define CONFIG_NANDSIM_DBG        0
> > >  #endif
> > > +#ifndef CONFIG_NANDSIM_MAX_PARTS
> > > +#define CONFIG_NANDSIM_MAX_PARTS  32
> > > +#endif
> > 
> > Since this is not a Kconfig option, please, remove the CONFIG_ prefix.
> 
> While I understand that CONFIG_* should be reserved to Kconfig, this is
> consistent with the existing build-time options in this file.

You are right. I remember long time ago that all were config options.
Now this is not the case anymore, and that stuff needs some clean up. So
I agree, it is fine to name it consistently.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)