* [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo
@ 2010-02-02 22:12 akpm
2010-02-03 8:07 ` Uwe Kleine-König
2010-02-09 12:13 ` Artem Bityutskiy
0 siblings, 2 replies; 6+ messages in thread
From: akpm @ 2010-02-02 22:12 UTC (permalink / raw)
To: dwmw2; +Cc: hsweeten, akpm, linux-mtd, peterhuewe, u.kleine-koenig
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
From: Peter Huewe <peterhuewe@gmx.de>
Fix a build failure introduced by the patch
mtd: orion_nand.c: add error handling and use resource_size()
The patch assigns something to a undeclared variable 'err', whereas the
rest of the code uses 'ret' for this task.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/mtd/nand/orion_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/mtd/nand/orion_nand.c~mtd-nand-fix-build-failure-caused-by-typo drivers/mtd/nand/orion_nand.c
--- a/drivers/mtd/nand/orion_nand.c~mtd-nand-fix-build-failure-caused-by-typo
+++ a/drivers/mtd/nand/orion_nand.c
@@ -92,7 +92,7 @@ static int __init orion_nand_probe(struc
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
- err = -ENODEV;
+ ret = -ENODEV;
goto no_res;
}
_
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo
2010-02-02 22:12 [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo akpm
@ 2010-02-03 8:07 ` Uwe Kleine-König
2010-02-10 18:15 ` David Woodhouse
2010-02-09 12:13 ` Artem Bityutskiy
1 sibling, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2010-02-03 8:07 UTC (permalink / raw)
To: akpm; +Cc: linux-mtd, peterhuewe, dwmw2, hsweeten
Hello Andrew,
> From: Peter Huewe <peterhuewe@gmx.de>
>
> Fix a build failure introduced by the patch
>
> mtd: orion_nand.c: add error handling and use resource_size()
>
> The patch assigns something to a undeclared variable 'err', whereas the
> rest of the code uses 'ret' for this task.
why did you add a ? to the subject? IMHO it should go in 2.6.33 as it's
an obvious build fix.
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo
2010-02-03 8:07 ` Uwe Kleine-König
@ 2010-02-10 18:15 ` David Woodhouse
2010-02-10 19:22 ` Artem Bityutskiy
0 siblings, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2010-02-10 18:15 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: hsweeten, akpm, linux-mtd, peterhuewe
On Wed, 2010-02-03 at 09:07 +0100, Uwe Kleine-König wrote:
> Hello Andrew,
>
> > From: Peter Huewe <peterhuewe@gmx.de>
> >
> > Fix a build failure introduced by the patch
> >
> > mtd: orion_nand.c: add error handling and use resource_size()
> >
> > The patch assigns something to a undeclared variable 'err', whereas the
> > rest of the code uses 'ret' for this task.
>
> why did you add a ? to the subject? IMHO it should go in 2.6.33 as
> it's an obvious build fix.
The build error isn't in 2.6.33 though -- it's only in linux-next.
Patch applied; thanks.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo
2010-02-10 18:15 ` David Woodhouse
@ 2010-02-10 19:22 ` Artem Bityutskiy
0 siblings, 0 replies; 6+ messages in thread
From: Artem Bityutskiy @ 2010-02-10 19:22 UTC (permalink / raw)
To: David Woodhouse
Cc: hsweeten, akpm, linux-mtd, peterhuewe, Uwe Kleine-König
On Wed, 2010-02-10 at 18:15 +0000, David Woodhouse wrote:
> On Wed, 2010-02-03 at 09:07 +0100, Uwe Kleine-König wrote:
> > Hello Andrew,
> >
> > > From: Peter Huewe <peterhuewe@gmx.de>
> > >
> > > Fix a build failure introduced by the patch
> > >
> > > mtd: orion_nand.c: add error handling and use resource_size()
> > >
> > > The patch assigns something to a undeclared variable 'err', whereas the
> > > rest of the code uses 'ret' for this task.
> >
> > why did you add a ? to the subject? IMHO it should go in 2.6.33 as
> > it's an obvious build fix.
>
> The build error isn't in 2.6.33 though -- it's only in linux-next.
>
> Patch applied; thanks.
Oh, right. We were all confused :-) The problem is solved now.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo
2010-02-02 22:12 [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo akpm
2010-02-03 8:07 ` Uwe Kleine-König
@ 2010-02-09 12:13 ` Artem Bityutskiy
2010-02-09 17:00 ` Andrew Morton
1 sibling, 1 reply; 6+ messages in thread
From: Artem Bityutskiy @ 2010-02-09 12:13 UTC (permalink / raw)
To: akpm; +Cc: hsweeten, peterhuewe, dwmw2, linux-mtd, u.kleine-koenig
On Tue, 2010-02-02 at 14:12 -0800, akpm@linux-foundation.org wrote:
> From: Peter Huewe <peterhuewe@gmx.de>
>
> Fix a build failure introduced by the patch
>
> mtd: orion_nand.c: add error handling and use resource_size()
>
> The patch assigns something to a undeclared variable 'err', whereas the
> rest of the code uses 'ret' for this task.
Andrew,
I think you should send this fix to Linus, since this is a build fix.
dwmw2 seem to bu unavailable now.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo
2010-02-09 12:13 ` Artem Bityutskiy
@ 2010-02-09 17:00 ` Andrew Morton
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2010-02-09 17:00 UTC (permalink / raw)
To: dedekind1; +Cc: hsweeten, peterhuewe, dwmw2, linux-mtd, u.kleine-koenig
On Tue, 09 Feb 2010 14:13:09 +0200 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Tue, 2010-02-02 at 14:12 -0800, akpm@linux-foundation.org wrote:
> > From: Peter Huewe <peterhuewe@gmx.de>
> >
> > Fix a build failure introduced by the patch
> >
> > mtd: orion_nand.c: add error handling and use resource_size()
> >
> > The patch assigns something to a undeclared variable 'err', whereas the
> > rest of the code uses 'ret' for this task.
>
> Andrew,
>
> I think you should send this fix to Linus, since this is a build fix.
> dwmw2 seem to bu unavailable now.
OK, no probs, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-02-10 19:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-02 22:12 [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo akpm
2010-02-03 8:07 ` Uwe Kleine-König
2010-02-10 18:15 ` David Woodhouse
2010-02-10 19:22 ` Artem Bityutskiy
2010-02-09 12:13 ` Artem Bityutskiy
2010-02-09 17:00 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).