From: Artem Bityutskiy <dedekind1@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: hsweeten@visionengravers.com, akpm@linux-foundation.org,
linux-mtd@lists.infradead.org, peterhuewe@gmx.de,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo
Date: Wed, 10 Feb 2010 21:22:25 +0200 [thread overview]
Message-ID: <1265829745.21361.2.camel@localhost.localdomain> (raw)
In-Reply-To: <1265825755.2529.2125.camel@macbook.infradead.org>
On Wed, 2010-02-10 at 18:15 +0000, David Woodhouse wrote:
> On Wed, 2010-02-03 at 09:07 +0100, Uwe Kleine-König wrote:
> > Hello Andrew,
> >
> > > From: Peter Huewe <peterhuewe@gmx.de>
> > >
> > > Fix a build failure introduced by the patch
> > >
> > > mtd: orion_nand.c: add error handling and use resource_size()
> > >
> > > The patch assigns something to a undeclared variable 'err', whereas the
> > > rest of the code uses 'ret' for this task.
> >
> > why did you add a ? to the subject? IMHO it should go in 2.6.33 as
> > it's an obvious build fix.
>
> The build error isn't in 2.6.33 though -- it's only in linux-next.
>
> Patch applied; thanks.
Oh, right. We were all confused :-) The problem is solved now.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-02-10 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 22:12 [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo akpm
2010-02-03 8:07 ` Uwe Kleine-König
2010-02-10 18:15 ` David Woodhouse
2010-02-10 19:22 ` Artem Bityutskiy [this message]
2010-02-09 12:13 ` Artem Bityutskiy
2010-02-09 17:00 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265829745.21361.2.camel@localhost.localdomain \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-mtd@lists.infradead.org \
--cc=peterhuewe@gmx.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox