linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd-utils: add option to not force largefile support
@ 2010-02-03  9:18 Peter Korsgaard
  2010-02-15 13:42 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2010-02-03  9:18 UTC (permalink / raw)
  To: linux-mtd, dedekind1

Not all systems have largefile support (E.G. uClibc depending on config),
so unconditionally enforcing largefile breaks the build.

Work around it by adding a WITHOUT_LARGEFILE flag, similar to the existing
WITHOUT_XATTR.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 common.mk |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/common.mk b/common.mk
index 5e92b07..d704b44 100644
--- a/common.mk
+++ b/common.mk
@@ -12,7 +12,10 @@ WFLAGS := -Wall \
 	$(call cc-option,-Wwrite-strings) \
 	$(call cc-option,-Wno-sign-compare)
 CFLAGS += $(WFLAGS)
-CPPFLAGS += -D_FILE_OFFSET_BITS=64
+
+ifneq ($(WITHOUT_LARGEFILE), 1)
+  CPPFLAGS += -D_FILE_OFFSET_BITS=64
+endif
 
 DESTDIR ?= /usr/local
 PREFIX=/usr
-- 
1.6.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd-utils: add option to not force largefile support
  2010-02-03  9:18 [PATCH] mtd-utils: add option to not force largefile support Peter Korsgaard
@ 2010-02-15 13:42 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-02-15 13:42 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: linux-mtd

On Wed, 2010-02-03 at 10:18 +0100, Peter Korsgaard wrote:
> Not all systems have largefile support (E.G. uClibc depending on config),
> so unconditionally enforcing largefile breaks the build.
> 
> Work around it by adding a WITHOUT_LARGEFILE flag, similar to the existing
> WITHOUT_XATTR.
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>

Pushed to mtd-utils.git, thanks!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-15 13:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-03  9:18 [PATCH] mtd-utils: add option to not force largefile support Peter Korsgaard
2010-02-15 13:42 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).