* Re-2: [PATCH 1/2] jffs2: Move erasing from write_super to GC.
@ 2010-02-18 12:41 Kai-Uwe Bloem
2010-02-18 13:06 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Kai-Uwe Bloem @ 2010-02-18 12:41 UTC (permalink / raw)
To: linux-mtd
> Right. You can move the signal check to the BGT, and do 1-3 erases at a
> time by passing cnt = 1-3. I think it is cleaner.
Seconded. I would restrict the count to 1, since some NOR flashes might need up to 4 seconds for one erase operation. OTOH, the count parameter would be superfluous in that case, since all the other invocations erase only one block as well.
--
To: dedekind1@gmail.com
joakim.tjernlund@transmode.se
Cc: linux-mtd@lists.infradead.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Re-2: [PATCH 1/2] jffs2: Move erasing from write_super to GC.
2010-02-18 12:41 Re-2: [PATCH 1/2] jffs2: Move erasing from write_super to GC Kai-Uwe Bloem
@ 2010-02-18 13:06 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-02-18 13:06 UTC (permalink / raw)
To: Kai-Uwe Bloem; +Cc: linux-mtd
On Thu, 2010-02-18 at 12:41 +0000, Kai-Uwe Bloem wrote:
> > Right. You can move the signal check to the BGT, and do 1-3 erases at a
> > time by passing cnt = 1-3. I think it is cleaner.
>
> Seconded. I would restrict the count to 1, since some NOR flashes
> might need up to 4 seconds for one erase operation. OTOH, the count
> parameter would be superfluous in that case, since all the other
> invocations erase only one block as well.
It might be superfluous, but it is not necessary to remove it.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-18 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-18 12:41 Re-2: [PATCH 1/2] jffs2: Move erasing from write_super to GC Kai-Uwe Bloem
2010-02-18 13:06 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).